[hurd] 04/15: libfshelp: Avoid useless allocations.

[Samuel Thibault]

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch dde
in repository hurd.

commit 978a819485e1e301c49b41fb629656d157d61ec6
Author: Justus Winter <address@hidden>
Date:   Wed Oct 5 15:07:37 2016 +0200

    libfshelp: Avoid useless allocations.
    
    * libfshelp/translator-list.c (fshelp_set_active_translator): Avoid
    allocating an entry unless a valid control port is given.
---
 libfshelp/translator-list.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libfshelp/translator-list.c b/libfshelp/translator-list.c
index c730ecd..5203128 100644
--- a/libfshelp/translator-list.c
+++ b/libfshelp/translator-list.c
@@ -89,6 +89,10 @@ fshelp_set_active_translator (struct port_info *pi,
   if (t)
     goto update; /* Entry exists.  */
 
+  if (! MACH_PORT_VALID (active))
+    /* Avoid allocating an entry just to delete it.  */
+    goto out;
+
   t = malloc (sizeof *t);
   if (! t)
     {

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git