[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Coreutils-announce] bad bug in test run by fileutils-4.1.10's `make che
From: |
Jim Meyering |
Subject: |
[Coreutils-announce] bad bug in test run by fileutils-4.1.10's `make check' |
Date: |
Sun, 21 Jul 2002 19:43:08 +0200 |
User-agent: |
Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.3.50 (i686-pc-linux-gnu) |
Thanks again, Mike.
From: Michael Stone <address@hidden>
Subject: rm test oops
The test was deleting random files in /tmp...
--- fileutils-4.1.10.orig/tests/rm/fail-eperm
+++ fileutils-4.1.10/tests/rm/fail-eperm
@@ -52,16 +52,17 @@
foreach my $f (readdir DIR_HANDLE)
{
+ my $target_file = "$dir/$f";
+
# Skip files owned by self, symlinks, and directories.
# It's not technically necessary to skip symlinks, but it's simpler.
- -l $f || -o _ || -d _
+ -l $target_file || -o _ || -d _
and next;
$found_file = 1;
# Invoke rm on this file and ensure that we get the
# expected exit code and diagnostic.
- my $target_file = "$dir/$f";
my $cmd = "rm -f $target_file";
open RM, "$cmd 2>&1 |"
or die "$ME: cannot execute `$cmd'\n";
--
Mike Stone
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Coreutils-announce] bad bug in test run by fileutils-4.1.10's `make check',
Jim Meyering <=