coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] fix a few nits


From: Jim Meyering
Subject: [coreutils] fix a few nits
Date: Sat, 04 Sep 2010 22:01:45 +0200

FYI,

    [PATCH 1/3] tac: suppress technically unneeded "free"
    [PATCH 2/3] build: use gettext-h, not gettext
    [PATCH 3/3] build: update gnulib submodule to latest


>From fc9d948d7e6ff916b3ddb3ed371a6f8aa7f2c624 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 28 Aug 2010 21:54:17 +0200
Subject: [PATCH 1/3] tac: suppress technically unneeded "free"

* src/tac.c (main): Guard final free with #ifdef lint.
Suggested by Paul Eggert.
---
 src/tac.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/tac.c b/src/tac.c
index 859e006..dbfe2b0 100644
--- a/src/tac.c
+++ b/src/tac.c
@@ -666,8 +666,10 @@ main (int argc, char **argv)
       ok = false;
     }

+#ifdef lint
   size_t offset = sentinel_length ? sentinel_length : 1;
   free (G_buffer - offset);
+#endif

   exit (ok ? EXIT_SUCCESS : EXIT_FAILURE);
 }
--
1.7.2.2.566.g36af9


>From 041c9c472a62fad027bdc76b62c11edd6d84cb3e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 3 Sep 2010 13:11:33 +0200
Subject: [PATCH 2/3] build: use gettext-h, not gettext

* bootstrap.conf (gnulib_modules): Use gettext-h, not gettext.
The latter is overkill for a package that uses
AM_GNU_GETTEXT([external]...
---
 bootstrap.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 31b1212..a0004ac 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -110,7 +110,7 @@ gnulib_modules="
   getopt-gnu
   getpagesize
   getpass-gnu
-  gettext
+  gettext-h
   gettime
   gettimeofday
   getugroups
--
1.7.2.2.566.g36af9


>From 0e295c88bccb7fe8aedbbcf1798fdfa8f6beec88 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 4 Sep 2010 14:25:11 +0200
Subject: [PATCH 3/3] build: update gnulib submodule to latest

---
 gnulib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gnulib b/gnulib
index a228f53..583c47d 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit a228f539d716ba1120173d7d5bf96bfbdc5e63aa
+Subproject commit 583c47de09e3fb912baa00ddd405ab66fdad433c
--
1.7.2.2.566.g36af9



reply via email to

[Prev in Thread] Current Thread [Next in Thread]