[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] [PATCH] truncate: fix a very unlikely case for undiagnos
|
From: |
Jim Meyering |
|
Subject: |
Re: [coreutils] [PATCH] truncate: fix a very unlikely case for undiagnosed errors |
|
Date: |
Mon, 25 Oct 2010 11:37:30 +0200 |
Pádraig Brady wrote:
> The attached is more to suppress any errors from
> possible future static analysis, than for any
> practical reason.
Thanks. That looks fine, but please defer it until after
the upcoming release.
> Subject: [PATCH] truncate: fix a very unlikely case for undiagnosed errors
>
> src/truncate.c (main): Use a bool to store if an error occurred,
> rather than an int, to protect against overflow.
> (do_ftruncate): Likewise. Also change so that 0/false means
> failure, and not success.