[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] [PATCH 1/5] tests: factor out VERBOSE-only --version-pri
|
From: |
Pádraig Brady |
|
Subject: |
Re: [coreutils] [PATCH 1/5] tests: factor out VERBOSE-only --version-printing code |
|
Date: |
Wed, 17 Nov 2010 22:24:29 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 17/11/10 21:31, Jim Meyering wrote:
> FYI, here are 5 change-sets to make a few hundred (mostly automated)
> changes like these:
>
> -test "$VERBOSE" = yes && chown --version
> +print_ver_ chown
>
> -test "$VERBOSE" = yes && { cp --version; mv --version; }
> +print_ver_ cp mv
>
> -test "$VERBOSE" = yes && { env -- pwd --version; readlink --version; }
> +print_ver_ pwd readlink
A nice refactoring. Looks good.
cheers,
Pádraig.