coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] [PATCH] tests: set fail=0 by default


From: Paul Eggert
Subject: [coreutils] [PATCH] tests: set fail=0 by default
Date: Fri, 17 Dec 2010 22:47:09 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7

I found this one by tracking down a bug with the latest snapshot
on Solaris.  Still haven't got to the real bug yet, but this bug
was getting in the way.

>From 7669bee6d7e9d0e806e42cb1033bd2b6642b7e9a Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Fri, 17 Dec 2010 22:39:47 -0800
Subject: [PATCH] tests: set fail=0 by default

* tests/init.sh (setup_): Set fail=0.  This was the intent as per
<http://lists.gnu.org/archive/html/bug-coreutils/2010-12/msg00058.html>
but the assignment in mktempd_ is ineffective, since mktempd_
is used inside `` and its assignments are in a subshell.
---
 tests/init.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tests/init.sh b/tests/init.sh
index a57de77..7be5e9e 100644
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -336,6 +336,9 @@ setup_()
   for sig_ in 1 2 3 13 15; do
     eval "trap 'Exit $(expr $sig_ + 128)' $sig_"
   done
+
+  # Set up for the "Exit $fail" at the end of many tests.
+  fail=0
 }
 
 # Create a temporary directory, much like mktemp -d does.
-- 
1.7.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]