coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: cp/sparse-fiemap: use "seq 99q" in place of "head -99


From: Bernhard Voelker
Subject: Re: [PATCH] tests: cp/sparse-fiemap: use "seq 99q" in place of "head -99"
Date: Tue, 21 Jun 2011 11:09:44 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10

On 06/21/2011 11:02 AM, Jim Meyering wrote:
Bernhard Voelker wrote:
There was still an obsolete use of "head -[1-9]" in tests.
The following patch replaces it.

Thanks, but actually no change is required there, since when running the
tests, we're guaranteed to be using coreutils' own version of "head".
By contrast, the just-fixed use in init.sh had no such protection, since
init.sh is used in other projects.

However, if you'd like to adjust your patch to make the test
use head -n99 instead (more readable than sed 99q and more future-proof
than "head -99", in case we stop supporting head -N), I'll apply it.


Thanks. The new patch is attached.

Have a nice day,
Berny

Attachment: head-n.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]