coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: configure:22781: error: possibly undefined macro: gl_REPLACE_FCLOSE


From: Bernhard Voelker
Subject: Re: configure:22781: error: possibly undefined macro: gl_REPLACE_FCLOSE
Date: Fri, 29 Jul 2011 11:34:21 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110616 SUSE/3.1.11 Thunderbird/3.1.11

On 07/27/2011 09:52 PM, Jim Meyering wrote:
Eric Blake wrote:
On 07/27/2011 05:33 AM, Bernhard Voelker wrote:
I messed up my git repo :-( - and cloned it anew.

$ rm -rf coreutils
$ git clone git://git.sv.gnu.org/coreutils
$ cd coreutils
$ ./bootstrap

However, the bootstrap step failed with the error in the subject.
The detailed log is attached.

Can you give me a hint what's wrong, please?

Coreutils upgraded to the latest gnulib without also upgrading
bootstrap.conf to explicitly pull in the fclose module.  It's a
one-liner patch to fix.

Thanks for the report and suggestion.
While the gnulib patch Pádraig referred to makes it so
fclose would no longer be required, we do want to use that module
to ensure we get a working replacement for the buggy fclose on at
least two relatively common systems:

 From e2bd7a288f4b4b0ac99350f3c6ac10cd97abf9a6 Mon Sep 17 00:00:00 2001
From: Jim Meyering<address@hidden>
Date: Wed, 27 Jul 2011 21:48:59 +0200
Subject: [PATCH] build: require gnulib's fclose module

* bootstrap.conf (gnulib_modules): Explicitly use the fclose module.
This is required, now that gnulib's close module no longer depends
on fclose.  This fixes fclose bugs affecting at least glibc 2.13
and FreeBSD.  Reported by Bernhard Voelker.  Suggested by Eric Blake.
---
  bootstrap.conf |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 937f7f3..0ba560c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -70,6 +70,7 @@ gnulib_modules="
    faccessat
    fadvise
    fchdir
+  fclose
    fcntl
    fcntl-safer
    fdl
--
1.7.6.639.g50fb9

I'm not sure if you're waiting on my test result to push it
(probably not), but the patch works for me. Thanks.

Have a nice day,
Berny



reply via email to

[Prev in Thread] Current Thread [Next in Thread]