Re: [PATCH] doc: date: mention that the hardware clock might not be set

[Jim Meyering]

Pádraig Brady wrote:
> commit a496b7ce575a12d952bb77eb9766719b4bd4ae6e
> Author: Pádraig Brady <address@hidden>
> Date:   Tue Nov 1 17:29:53 2011 +0000
>
>     doc: date: mention that the hardware clock might not be set
>
>     * doc/coreutils.texi (Setting the time): Reorganize slightly
>     and mention that the hardware clock might need to be explicitly
>     updated by the user as is the case on Fedora 16 currently.

Thanks.  The change looks fine.
I'll nit-pick the log a little, though ;-)

Isn't it KDE-specific?

      updated by the user as is currently the case with Fedora 16's KDE.

>     See https://bugzilla.redhat.com/show_bug.cgi?id=749516

How about the shorter equivalent? (dropping the "s" in https
as well as /sh.*id=/):

      See http://bugzilla.redhat.com/749516

To help remember, I'll be using the patch below.

> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> index 9233194..424a431 100644
> --- a/doc/coreutils.texi
> +++ b/doc/coreutils.texi
> @@ -14188,11 +14188,9 @@ is available, it is ignored.
>  If given an argument that does not start with @samp{+}, @command{date} sets
>  the system clock to the date and time specified by that argument (as
>  described below).  You must have appropriate privileges to set the
> -system clock.  The @option{--date} and @option{--set} options may not be
> -used with such an argument.  The @option{--universal} option may be used
> -with such an argument to indicate that the specified date and time are
> -relative to Coordinated Universal Time rather than to the local time
> -zone.
> +system clock.  Note for changes to persist across a reboot, the
> +hardware clock may need to be updated from the system clock, which
> +might not happen automatically on your system.

It doesn't hurt to mention it, but the current situation with KDE
seems to be solely due to a bug.

How about this?

>From 113292de2822759483d538a1814f1c94cfd580fb Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 1 Nov 2011 20:54:37 +0100
Subject: [PATCH] scripts: reject references to long-form bug URLs

* scripts/git-hooks/commit-msg: Require the normalized/shortened
form of bugzilla.redhat.com and bugs.gnu.org bug URLs.
---
 scripts/git-hooks/commit-msg |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
index 77703fa..96d5947 100755
--- a/scripts/git-hooks/commit-msg
+++ b/scripts/git-hooks/commit-msg
@@ -56,6 +56,12 @@ check_msg()
   test "$(get_msg | sed -n 2p)" \
     && { echo "second line should be blank"; return 1; }

+  get_msg | grep -E 'https?://bugzilla\.redhat\.com/show_bug\.cgi' >&2 \
+    && { echo 'use shorter http://bugzilla.redhat.com/NNNNNN'; return 1; }
+
+  get_msg | grep -E 'https?://debbugs\.gnu\.org/cgi/bugreport\.cgi?bug=' >&2 \
+    && { echo 'use shorter http://bugs.gnu.org/NNNNN'; return 1; }
+
   # Flag redundant use of "issue"
   get_msg | grep -Fi "issue reported by" >&2 \
     && { echo "just say: Reported by ..."; return 1; }
--
1.7.7.1.476.g9890