Re: rename: move command from util-linux to coreutils

[Jim Meyering]

Sami Kerola wrote:

> On Sun, Jun 10, 2012 at 10:36 PM, Jim Meyering <address@hidden> wrote:
>
> Hi Jim et.al.
>
>> Thanks for the suggestion.
>> Have you already discussed this on the util-linux list and/or
>> with Karel Zak?
>
> Yes I did. As a matter of fact the proposal is rather old. First time
> thought moving the command out of util-linux to coreutils was at
> summer 2011, when few mails where sent back and forth.
>
> https://lists.gnu.org/archive/html/coreutils/2011-06/msg00080.html
>
> Now when su moved I thought it's good moment to try doing this as well.
>
>> Here's some quick feedback after a very cursory look:
>> I see unchecked syscalls, from write and waitpid to close and dup2.
>
> I'll correct that to my git tomorrow.
>
>> Style nits: I saw "TYPE * var_name" in at least one declaration.
>> I think it was a parameter list.
>> It should be "TYPE *var_name".
>
> Uh, oh. I cannot trust 'indent -gnu rename.c' fixing everything. I
> will fix this at same go with unchecked syscalls.

With GNU indent, you have to specify types that are unknown
to it via e.g., -Tuintmax_t

>> I also saw a TAB or two used in indentation.  Use only spaces.
>> If you run "make syntax-check", it will show you where.
>
> Same for this.

Use indent --no-tabs

>> Providing more test coverage would be most useful/welcome.
>
> I will write at least --exec test.

Good.  Thanks!