[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: avoid rare error-path FD leak
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] tail: avoid rare error-path FD leak |
|
Date: |
Thu, 02 Aug 2012 17:21:57 +0200 |
Pádraig Brady wrote:
> On 08/02/2012 03:52 PM, Jim Meyering wrote:
>> FYI,
>>
>> Subject: [PATCH] tail: avoid rare error-path FD leak
>>
>> * src/tail.c (tail_forever): Close FD to avoid leak after a
>> failed fstat.
...
> static analysis or eagle eyes?
> Change looks good.
Thanks.
I noticed it while working on another patch that I'll post soon,
to address this TODO entry:
tail: don't use xlseek; it *exits*.