coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/3] tests: reverse args in Coreutils.pm-invoked diff, for consis


From: Jim Meyering
Subject: [PATCH 3/3] tests: reverse args in Coreutils.pm-invoked diff, for consistency
Date: Thu, 16 Aug 2012 20:22:18 +0200

From: Jim Meyering <address@hidden>

* tests/Coreutils.pm (_compare_files): Reverse diff arguments so
that we invoke diff -c $expected $actual, which is consistent with
how init.sh-using tests invoke "compare exp out".
---
 tests/Coreutils.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/Coreutils.pm b/tests/Coreutils.pm
index 0c8bb82..a0c1bba 100644
--- a/tests/Coreutils.pm
+++ b/tests/Coreutils.pm
@@ -130,14 +130,14 @@ sub _compare_files ($$$$$)
 {
   my ($program_name, $test_name, $in_or_out, $actual, $expected) = @_;

-  my $differ = compare ($expected, $actual);
+  my $differ = compare ($actual, $expected);
   if ($differ)
     {
       my $info = (defined $in_or_out ? "std$in_or_out " : '');
       warn "$program_name: test $test_name: ${info}mismatch, comparing "
-        . "$actual (actual) and $expected (expected)\n";
+        . "$expected (expected) and $actual (actual)\n";
       # Ignore any failure, discard stderr.
-      system "diff -c $actual $expected 2>/dev/null";
+      system "diff -c $expected $actual 2>/dev/null";
     }

   return $differ;
-- 
1.7.12.rc2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]