coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 09/22] build: add an explicative comment


From: Stefano Lattarini
Subject: [PATCH 09/22] build: add an explicative comment
Date: Wed, 29 Aug 2012 23:54:46 +0200

* man/Makefile.am (EXTRA_DIST): Here, portability issues of the
employed idiom.  Reformat the definition a little while at it.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 man/Makefile.am | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/man/Makefile.am b/man/Makefile.am
index 8e9df08..44eb310 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -19,10 +19,19 @@ dist_man1_MANS = $(MAN)
 
 man_aux = $(dist_man1_MANS:.1=.x)
 
-EXTRA_DIST = $(man_aux) $(NO_INSTALL_PROGS_DEFAULT:%=%.x) help2man \
-       $(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+EXTRA_DIST = $(man_aux) help2man
 MAINTAINERCLEANFILES = $(dist_man1_MANS)
 
+# The "$(VAR:%=%.x)" idiom is not portable according to POSIX, but in
+# practice it works with several make implementation (GNU, BSD, CCS make
+# from Solaris 10, Sun distributed make).  In addition, since only
+# maintainers are expected to build release tarballs (and they should
+# use GNU make when doing so), it's not big deal if this won't work with
+# some dumber make implementation.
+EXTRA_DIST += \
+  $(NO_INSTALL_PROGS_DEFAULT:%=%.x) \
+  $(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+
 # Depend on ../.version to get version number changes.
 common_dep = ../.version
 
-- 
1.7.12




reply via email to

[Prev in Thread] Current Thread [Next in Thread]