Re: [PATCH 0/6] Patches to avoid use of make recursion in the 'src/' subdir

[Jim Meyering]

Jim Meyering wrote:
> Stefano Lattarini wrote:
>
>> On 08/31/2012 03:34 PM, Jim Meyering wrote:
>>> Stefano Lattarini wrote:
>>>> These should go on the top of my other pending series "[PATCH 0/7] Minor
>>>> cleanup and refactoring":
>>>>
>>>>     <http://lists.gnu.org/archive/html/coreutils/2012-08/msg00205.html>
>>>
>>> Thanks!  Looking at these now.
>>> FYI, I pushed that other series an hour ago.
>>>
>> Ouch, some of them still have the S-o-B line!  Can you delete those, or
>> should I resend?
>
> No problem.  As I tried to apply them with "git am FILE",
> the new commit hook complained and left me in the editor,
> where I removed them.
>
> However, 3/6 failed to apply.
> It took a little effort to make it apply, so I'm attaching below
> what I am now looking at.  FYI, I've just confirmed it passed "make check"
> but not "make syntax-check".

Hmm... actually there are a few other problems.  See below.
If you don't mind fixing those and reposting, I would be grateful.
I'm stepping out for an hour or so.

Here's the output of this:

    make -j1 -k syntax-check

GFDL_version
0.04 GFDL_version
GPL_version
0.04 GPL_version
NEWS_two_empty_lines
0.01 NEWS_two_empty_lines
THANKS_in_duplicates
0.34 THANKS_in_duplicates
Wundef_boolean
0.30 Wundef_boolean
avoid_if_before_free
0.13 avoid_if_before_free
bindtextdomain
0.03 bindtextdomain
cast_of_alloca_return_value
0.04 cast_of_alloca_return_value
cast_of_argument_to_free
0.05 cast_of_argument_to_free
cast_of_x_alloc_return_value
0.04 cast_of_x_alloc_return_value
changelog
0.02 changelog
check-AUTHORS
make[1]: *** No rule to make target `Makefile.am', needed by `Makefile.in'.
make[1]: *** No rule to make target `../src/Makefile.am', needed by 
`../config.status'.
make[1]: Failed to remake makefile `Makefile'.
make[1]: Target `_sc_check-AUTHORS' not remade because of errors.
make: *** [sc_check-AUTHORS] Error 2
const_long_option
0.04 const_long_option
copyright_check
0.34 copyright_check
cross_check_PATH_usage_in_tests
0.00 cross_check_PATH_usage_in_tests
dd_O_FLAGS
0.03 dd_O_FLAGS
dd_max_sym_length
0.01 dd_max_sym_length
error_exit_success
0.03 error_exit_success
error_message_period
0.04 error_message_period
error_message_uppercase
0.04 error_message_uppercase
error_message_warn_fatal
0.04 error_message_warn_fatal
file_system
0.05 file_system
immutable_NEWS
0.01 immutable_NEWS
long_lines
2.33 long_lines
m4_quote_check
0.02 m4_quote_check
makefile_TAB_only_indentation
src/local.mk:371:                               $(srcdir)/src/dircolors.hin > 
$@-t
src/local.mk:453:                         --local $(srcdir)/src/stat.c > $@t
src/local.mk:461:                         $(srcdir)/src/stat.c > $@t
maint.mk: found TAB-8-space indentation
make: *** [sc_makefile_TAB_only_indentation] Error 1
makefile_at_at_check
0.02 makefile_at_at_check
makefile_path_separator_check
0.02 makefile_path_separator_check
missing src/chroot.x
missing src/hostid.x
missing src/nice.x
missing src/who.x
missing src/users.x
missing src/pinky.x
missing src/uptime.x
missing src/stty.x
missing src/df.x
missing src/stdbuf.x
missing src/[.x
missing src/base64.x
missing src/basename.x
missing src/cat.x
missing src/chcon.x
missing src/chgrp.x
missing src/chmod.x
missing src/chown.x
missing src/cksum.x
missing src/comm.x
missing src/cp.x
missing src/csplit.x
missing src/cut.x
missing src/date.x
missing src/dd.x
missing src/dir.x
missing src/dircolors.x
missing src/dirname.x
missing src/du.x
missing src/echo.x
missing src/env.x
missing src/expand.x
missing src/expr.x
missing src/factor.x
missing src/false.x
missing src/fmt.x
missing src/fold.x
missing src/ginstall.x
missing src/groups.x
missing src/head.x
missing src/id.x
missing src/join.x
missing src/kill.x
missing src/link.x
missing src/ln.x
missing src/logname.x
missing src/ls.x
missing src/md5sum.x
missing src/mkdir.x
missing src/mkfifo.x
missing src/mknod.x
missing src/mktemp.x
missing src/mv.x
missing src/nl.x
missing src/nproc.x
missing src/nohup.x
missing src/od.x
missing src/paste.x
missing src/pathchk.x
missing src/pr.x
missing src/printenv.x
missing src/printf.x
missing src/ptx.x
missing src/pwd.x
missing src/readlink.x
missing src/realpath.x
missing src/rm.x
missing src/rmdir.x
missing src/runcon.x
missing src/seq.x
missing src/sha1sum.x
missing src/sha224sum.x
missing src/sha256sum.x
missing src/sha384sum.x
missing src/sha512sum.x
missing src/shred.x
missing src/shuf.x
missing src/sleep.x
missing src/sort.x
missing src/split.x
missing src/stat.x
missing src/sum.x
missing src/sync.x
missing src/tac.x
missing src/tail.x
missing src/tee.x
missing src/test.x
missing src/timeout.x
missing src/touch.x
missing src/tr.x
missing src/true.x
missing src/truncate.x
missing src/tsort.x
missing src/tty.x
missing src/uname.x
missing src/unexpand.x
missing src/uniq.x
missing src/unlink.x
missing src/vdir.x
missing src/wc.x
missing src/whoami.x
missing src/yes.x
missing src/arch.x
missing src/hostname.x
missing src/chroot.x
missing src/df.x
missing src/hostid.x
missing src/libstdbuf.so.x
missing src/nice.x
missing src/pinky.x
missing src/stdbuf.x
missing src/stty.x
missing src/uptime.x
missing src/users.x
missing src/who.x
missing src/[.x
missing src/base64.x
missing src/basename.x
missing src/cat.x
missing src/chcon.x
missing src/chgrp.x
missing src/chmod.x
missing src/chown.x
missing src/cksum.x
missing src/comm.x
missing src/cp.x
missing src/csplit.x
missing src/cut.x
missing src/date.x
missing src/dd.x
missing src/dir.x
missing src/dircolors.x
missing src/dirname.x
missing src/du.x
missing src/echo.x
missing src/env.x
missing src/expand.x
missing src/expr.x
missing src/factor.x
missing src/false.x
missing src/fmt.x
missing src/fold.x
missing src/ginstall.x
missing src/groups.x
missing src/head.x
missing src/id.x
missing src/join.x
missing src/kill.x
missing src/link.x
missing src/ln.x
missing src/logname.x
missing src/ls.x
missing src/md5sum.x
missing src/mkdir.x
missing src/mkfifo.x
missing src/mknod.x
missing src/mktemp.x
missing src/mv.x
missing src/nl.x
missing src/nproc.x
missing src/nohup.x
missing src/od.x
missing src/paste.x
missing src/pathchk.x
missing src/pr.x
missing src/printenv.x
missing src/printf.x
missing src/ptx.x
missing src/pwd.x
missing src/readlink.x
missing src/realpath.x
missing src/rm.x
missing src/rmdir.x
missing src/runcon.x
missing src/seq.x
missing src/sha1sum.x
missing src/sha224sum.x
missing src/sha256sum.x
missing src/sha384sum.x
missing src/sha512sum.x
missing src/shred.x
missing src/shuf.x
missing src/sleep.x
missing src/sort.x
missing src/split.x
missing src/stat.x
missing src/sum.x
missing src/sync.x
missing src/tac.x
missing src/tail.x
missing src/tee.x
missing src/test.x
missing src/timeout.x
missing src/touch.x
missing src/tr.x
missing src/true.x
missing src/truncate.x
missing src/tsort.x
missing src/tty.x
missing src/uname.x
missing src/unexpand.x
missing src/uniq.x
missing src/unlink.x
missing src/vdir.x
missing src/wc.x
missing src/whoami.x
missing src/yes.x
make: *** [check-programs-vs-x] Error 1
man_file_correlation
no_exec_perl_coreutils
0.02 no_exec_perl_coreutils
obsolete_symbols
0.04 obsolete_symbols
option_desc_uppercase
0.01 option_desc_uppercase
po_check
2.31 po_check
preprocessor_indentation
0.04 preprocessor_indentation
program_name
0.03 program_name
prohibit_HAVE_MBRTOWC
0.04 prohibit_HAVE_MBRTOWC
prohibit_S_IS_definition
0.04 prohibit_S_IS_definition
prohibit_always-defined_macros
0.45 prohibit_always-defined_macros
prohibit_always_true_header_tests
0.05 prohibit_always_true_header_tests
prohibit_argmatch_without_use
0.04 prohibit_argmatch_without_use
prohibit_assert_without_use
0.04 prohibit_assert_without_use
prohibit_atoi_atof
0.05 prohibit_atoi_atof
prohibit_backup_files
0.02 prohibit_backup_files
prohibit_c_ctype_without_use
0.04 prohibit_c_ctype_without_use
prohibit_canonicalize_without_use
0.04 prohibit_canonicalize_without_use
prohibit_cloexec_without_use
0.04 prohibit_cloexec_without_use
prohibit_close_stream_without_use
0.03 prohibit_close_stream_without_use
prohibit_continued_string_alpha_in_column_1
0.03 prohibit_continued_string_alpha_in_column_1
prohibit_cvs_keyword
0.04 prohibit_cvs_keyword
prohibit_defined_have_decl_tests
0.04 prohibit_defined_have_decl_tests
prohibit_dirent_without_use
0.03 prohibit_dirent_without_use
prohibit_doubled_word
0.45 prohibit_doubled_word
prohibit_emacs__indent_tabs_mode__setting
0.04 prohibit_emacs__indent_tabs_mode__setting
prohibit_empty_lines_at_EOF
0.03 prohibit_empty_lines_at_EOF
prohibit_error_without_use
0.04 prohibit_error_without_use
prohibit_fail_0
0.04 prohibit_fail_0
prohibit_framework_failure
0.04 prohibit_framework_failure
prohibit_getopt_without_use
0.04 prohibit_getopt_without_use
prohibit_hash_pjw_without_use
0.03 prohibit_hash_pjw_without_use
prohibit_hash_without_use
0.04 prohibit_hash_without_use
prohibit_have_config_h
0.04 prohibit_have_config_h
prohibit_ignore_value_without_use
0.04 prohibit_ignore_value_without_use
prohibit_intprops_without_use
0.03 prohibit_intprops_without_use
prohibit_inttostr_without_use
0.03 prohibit_inttostr_without_use
prohibit_jm_in_m4
0.02 prohibit_jm_in_m4
prohibit_long_options_without_use
0.04 prohibit_long_options_without_use
prohibit_magic_number_exit
0.05 prohibit_magic_number_exit
prohibit_man_see_also_period
0.02 prohibit_man_see_also_period
prohibit_openat_without_use
0.04 prohibit_openat_without_use
prohibit_operator_at_end_of_line
0.04 prohibit_operator_at_end_of_line
prohibit_path_max_allocation
0.04 prohibit_path_max_allocation
prohibit_perl_hash_quotes
0.05 prohibit_perl_hash_quotes
prohibit_posixver_without_use
0.04 prohibit_posixver_without_use
prohibit_quote_without_use
0.04 prohibit_quote_without_use
prohibit_quotearg_without_use
0.03 prohibit_quotearg_without_use
prohibit_readlink
0.04 prohibit_readlink
prohibit_reversed_compare_failure
0.04 prohibit_reversed_compare_failure
prohibit_root_dev_ino_without_use
0.04 prohibit_root_dev_ino_without_use
prohibit_safe_read_without_use
0.03 prohibit_safe_read_without_use
prohibit_same_without_use
0.04 prohibit_same_without_use
prohibit_short_facl_mode_spec
0.05 prohibit_short_facl_mode_spec
prohibit_signal_without_use
0.05 prohibit_signal_without_use
prohibit_sleep
0.04 prohibit_sleep
prohibit_stat_macro_address
0.04 prohibit_stat_macro_address
prohibit_stat_st_blocks
0.04 prohibit_stat_st_blocks
prohibit_stddef_without_use
0.04 prohibit_stddef_without_use
prohibit_stdio--_without_use
0.04 prohibit_stdio--_without_use
prohibit_stdio-safer_without_use
0.04 prohibit_stdio-safer_without_use
prohibit_strcmp
0.04 prohibit_strcmp
prohibit_strings_without_use
0.03 prohibit_strings_without_use
prohibit_strncmp
0.04 prohibit_strncmp
prohibit_strncpy
0.04 prohibit_strncpy
prohibit_tab_based_indentation
0.04 prohibit_tab_based_indentation
prohibit_test_backticks
0.03 prohibit_test_backticks
prohibit_test_calls_print_ver_with_irrelevant_argument
0.80 prohibit_test_calls_print_ver_with_irrelevant_argument
prohibit_test_double_equal
0.05 prohibit_test_double_equal
prohibit_test_minus_ao
0.04 prohibit_test_minus_ao
prohibit_undesirable_word_seq
1.94 prohibit_undesirable_word_seq
prohibit_verbose_version
0.04 prohibit_verbose_version
prohibit_verify_without_use
0.04 prohibit_verify_without_use
prohibit_xalloc_without_use
0.04 prohibit_xalloc_without_use
prohibit_xfreopen_without_use
0.03 prohibit_xfreopen_without_use
proper_name_utf8_requires_ICONV
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
Can't open src/Makefile.am: No such file or directory.
0.07 proper_name_utf8_requires_ICONV
redundant_const
0.04 redundant_const
require_config_h
0.02 require_config_h
require_config_h_first
0.24 require_config_h_first
require_stdio_safer
0.04 require_stdio_safer
require_test_exit_idiom
0.00 require_test_exit_idiom
root_tests
0.04 root_tests
some_programs_must_avoid_exit_failure
0.03 some_programs_must_avoid_exit_failure
space_before_open_paren
0.65 space_before_open_paren
space_tab
src/local.mk:58:EXTRA_DIST +=           \
src/local.mk:59:  src/dcgen             \
maint.mk: found SPACE-TAB sequence; remove the SPACE
make: *** [sc_space_tab] Error 1
strftime_check
0.06 strftime_check
sun_os_names
0.05 sun_os_names
system_h_headers
0.04 system_h_headers
texinfo_acronym
0.02 texinfo_acronym
tight_scope
maint.mk: skipping sc_tight_scope
0.01 tight_scope
trailing_blank
0.06 trailing_blank
two_space_separator_in_usage
0.04 two_space_separator_in_usage
unmarked_diagnostics
0.04 unmarked_diagnostics
useless_cpp_parens
0.04 useless_cpp_parens
vulnerable_makefile_CVE-2009-4029
0.30 vulnerable_makefile_CVE-2009-4029
vulnerable_makefile_CVE-2012-3386
0.30 vulnerable_makefile_CVE-2012-3386
make: Target `syntax-check' not remade because of errors.