Re: bug#8938: make timeout and CTRL-C

[Jim Meyering]

Pádraig Brady wrote:

> On 09/12/2012 03:31 AM, Pádraig Brady wrote:
>> I found a more reliable way to disable core dumps,
>> so another attempt at this is attached.
>
> V2 attached, which factors out a disable_core_dumps() function.

Good idea.

> Subject: [PATCH] timeout: handle signals more transparently
>
...
> +  error (0, errno, _("warning: disabling core dumps failed"));

Looks fine, though confess I didn't test it.
One tiny suggestion: tweak this diagnostic:

  -    error (0, errno, _("warning: disabling core dumps failed"));
  +    error (0, errno, _("warning: failed to disable core dumps"));

IMHO, that's a little more understandable.