Re: [PATCH] df: port the new df test to POSIX sed, larger file systems

[Stefano Lattarini]

On 11/22/2012 01:36 PM, Bernhard Voelker wrote:
> On 11/22/2012 01:25 PM, Stefano Lattarini wrote:
>> Hi Pádraig, Bernhard.
>>
>> On 11/22/2012 12:52 PM, Pádraig Brady wrote:
>>>
>>>>   df --help > out || fail=1
>>>> -grep ' --output' out | sed 's/^.*\(--output\).*$/\1/;q' > out2
>>>> -compare exp out2 || fail=1
>>>> +grep ' --output' out >/dev/null || fail=1
>>>
>> Why this extra redirection to /dev/null?  I think the output from
>> the tests should be as verbose as possible, to simplify debugging
>> and analysis.  Granted, not a big deal here, but IMHO it's better
>> to be consistent and avoid gratuitous null redirections.
> 
> I was first thinking about 'grep -q', but there's only one use in
> cfg.mk (nowhere else). Is that disliked?
>
"grep -q" is not portable AFAIK.

> Therefore, I thought that the redirection to /dev/null
> would be best ... as there are many others in tests:
> 
>   git grep 'grep .*/dev/null' | grep ^tests | wc -l
>   45
> 
> And I see your point: test logs should contain as must info
> as possible. That's even better.
>
Glad you agree.

> Before sending, I even thought about 'cat out' in case of failures,
> something like:
> 
>   compare exp out2 || { fail=1 ; cat out; }
>
Doesn't the 'compare' shell function automatically display the diffs
anyway (if there are any)?  In which case, an extra cat might be a
little overkill (but certainly it wouldn't hurt).

Regards,
  Stefano