Re: [PATCH] cp caching

[Ondrej Oprala]

On 01/03/2013 02:12 PM, Jim Meyering wrote:
> >         bool all_errors = !x->data_copy_required || x->require_preserve_context;
> >         bool some_errors = !all_errors && !x->reduce_diagnostics;
> However, both of these declarations belong inside the if {...} body.
What exactly do you mean? Moving the declarations deeper would put
them out of the else {...} body's scope.

> Also, please change the name and meaning of s/con_eq/context_change/
Done.

On 01/03/2013 02:15 PM, Pádraig Brady wrote:
> This makes sense. It might be worth a news entry,
> especially if you quantified the perf benefit.
Done.
> The code looks a bit fishy, mixing security_context_t and char*.
Yes, I wasn't very happy about using security_context_t in this way
either, but it seemed like the most straightforward solution.

Thanks,
 Ondrej

DIFF
Description: Text document