Re: Make mv work better with SELinux.

[Pádraig Brady]

On 01/09/2013 05:15 PM, Daniel J Walsh wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01/09/2013 11:02 AM, Pádraig Brady wrote:
> > On 01/09/2013 03:50 PM, Daniel J Walsh wrote:
> > > -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> > >
> > > Any word on this patch making its way upstream?  Or is there something
> > > else I need to do?
> >
> > It's still on my todo list. I expect to finish the review soonish and have
> > it in the next release.
> >
> > thanks, Pádraig.
>
> Excellent.  Thanks.  BTW We just received a patch from  Ondrej Oprala for
> libselinux which according to him,
>
> "I tested the patched libselinux with
> $cp -a dir1 dir2
> and got an approx. 20% save in instruction count. "
>
> Basically the patch caches calls to setfscreatecon() and if the context is the
> same as the previous call, it does a noop (Well it needs to do a strcmp) but
> does not need to write to the /sys/fs/selinux file system.
>
> Should make large cp's which maintain attributes, work a little faster.  Or
> any other tools in coreutils that do lots of setfscreatecon calls.
>
> rpm -q libselinux
> libselinux-2.1.12-12.fc19.x86_64

Cool, I hinted at that here:
http://lists.gnu.org/archive/html/coreutils/2013-01/msg00013.html
So we won't need to worry about a coreutils patch for that.

thanks,
Pádraig.