|
From: | Pádraig Brady |
Subject: | Re: [PATCH] id: fix: check return value of smack_new_label_from_self() < 0 |
Date: | Thu, 20 Jun 2013 21:30:22 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
The logic looks Ok here, but there is context missing. I needed to read back to know what was going on. I'll augment the commit message with something along the lines of: m4/jm-macros.m4: Set HAVE_SMACK when both smack_new_label_from_self() and recently added smack_new_label_from_path() are present. The latter's presence indicates the newer API of the former. thanks, Pádraig. p.s. Try to maintain threading. git send-email has --in-reply-to.
[Prev in Thread] | Current Thread | [Next in Thread] |