Re: [PATCH] md5sum, sha*sum: use libcrypto where available

[Pádraig Brady]

On 12/04/2013 01:39 PM, Bernhard Voelker wrote:
> On 12/04/2013 02:28 PM, Pádraig Brady wrote:
>> Pushed.
>>
>> Snapshot for 8.22 coming real soon now.
>> Yell if there is something you'd like included.
> 
> I see the --with-openssl option twice in "./configure --help" output
> which looks odd (I'm on v8.21-174-gb53b0fd):
> 
> 
>   --with-openssl          The coreutils default is: --with-openssl=optional
>   --with-openssl          use libcrypto hash routines. Valid ARGs are: 'yes',
>                           'no', 'optional' => use if available

I've documented the reason for that at least in configure.ac:

dnl Enable use of libcrypto if available.
dnl Note we could do this as follows:
dnl   AS_VAR_SET_IF([with_openssl], [], [with_openssl=optional])
dnl However that would not document the coreutils adjusted default,
dnl so we add another --with-openssl description just to document that

It's the best I could come up with for now,
and I don't think it's too bad?

To fix elegantly may need improvements to AC_ARG_WITH.

thanks,
Pádraig.