[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tests/ls/stat-free-colors.sh broken with glibc-2.22
From: |
Pádraig Brady |
Subject: |
Re: tests/ls/stat-free-colors.sh broken with glibc-2.22 |
Date: |
Thu, 03 Sep 2015 23:58:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 03/09/15 22:21, Roland McGrath wrote:
> That libc change was intended to be a pure refactoring and should not have
> changed the behavior at all. That it caused the extra stat is a bug (it's
> a simple inverted test typo).
>
> This is in the grey area of whether the bug was "user-visible", but a
> performance regression that bubbles up to perceptibility seems like it
> qualifies. So please file a bug at https://sourceware.org/bugzilla
> (you can assign it directly to address@hidden).
https://sourceware.org/bugzilla/show_bug.cgi?id=18921
> Unfortunately, I can't think of a way to write a real regression test for
> this in the libc test suite. We don't really do "external" things like
> use strace to determine if a test passes.
There would probably need to be some mocking infrastructure
in place to record and match API calls. Much easier in
a language like python with built in introspection etc.
thanks Roland!
Pádraig.