[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: fix determination of remoteness without inotify
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] tail: fix determination of remoteness without inotify |
|
Date: |
Wed, 23 Nov 2016 12:11:42 -0800 |
On Wed, Nov 23, 2016 at 11:18 AM, Pádraig Brady <address@hidden> wrote:
> In recent commit v8.25-93-g7fc7206 we used the f-remote flag
> which wasn't set in all cases. This was detected with
> ASAN giving this error when reading f->remote;
> runtime error: load of value 190,
> which is not a valid value for type '_Bool'
>
> * src/tail.c (fremote): Query the system even without inotify.
> (recheck): Always set f->fremote for valid files.
Good catch!
Thank you.