coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new snapshot available: coreutils-8.25.120-ca99c


From: Pádraig Brady
Subject: Re: new snapshot available: coreutils-8.25.120-ca99c
Date: Mon, 28 Nov 2016 17:31:25 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 28/11/16 14:54, Pádraig Brady wrote:
>> FAIL: tests/misc/head-write-error
>> >    =================================
>> >    + diff -u exp err
>> >    --- exp 2016-11-25 22:08:55.826372000 +0000
>> >    +++ err 2016-11-25 22:08:55.842703000 +0000
>> >    @@ -1 +1 @@
>> >    -head: error writing 'standard output'
>> >    +head: 'standard input': cannot seek to offset 65535
>> >    + fail=1
> Hmm, that implies that st->st_size > ST_BLKSIZE(*st)
> for pipes on FreeBSD 11. Maybe we should explicitly
> disallow st_size==0 for the seekable case?
> More generally should we fall back to the nonseekable
> path if the seek fails.
> 
> Also the sed adjustment to the error doesn't seem to be working?
> I.E. I'm surprised to see the ": cannot seek..." portion of the message.
> 
> I'll see can I test on a VM...

Assaf your testing VMs and instructions are awesome!!
http://www.nongnu.org/pretest/

The attached patch fixes the above issue there.

thanks,
Pádraig

Attachment: head-pipe-bsd.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]