[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] copy: make backup files more reliably
|
From: |
Kamil Dudka |
|
Subject: |
Re: [PATCH 3/4] copy: make backup files more reliably |
|
Date: |
Thu, 03 Aug 2017 15:02:18 +0200 |
|
User-agent: |
KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) |
On Thursday, August 03, 2017 04:17:40 Paul Eggert wrote:
> Yes, I know that, but there's no easy way to change that without introducing
> a race condition the other way. I thought it better to be conservative and
> reject the (extremely unusual) case that you mentioned, rather than make
> the common case significantly less-efficient or (worse) to lose data in
> some rare cases.
Yes, the API of backup_file_rename() is too coarse for that.
> I suppose we could change the diagnostic to say "might destroy source"
> rather than "would destroy source". That would be more accurate.
Sounds reasonable.
Kamil