[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ls: consistently quote symlink targets
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] ls: consistently quote symlink targets |
|
Date: |
Thu, 24 Aug 2017 18:30:28 -0700 |
On Thu, Aug 24, 2017 at 12:28 AM, Pádraig Brady <address@hidden> wrote:
> * src/ls.c (gobble_file): Disable the optimization to avoid quoting
> if the symlink target itself needs quoting. This was introduced
> with the quoting alignment adjustments in v8.25-106-g01971c0
> * tests/ls/symlink-quote.sh: Add a test.
> * tests/local.mk: Reference the test.
> * NEWS: Mention the fix.
> +++ b/NEWS
...
> + ls now quotes symlink targets when consistently. Previously it may not
> + have quoted the target name if the link name itself didn't need quoting.
> + [bug introduced in coreutils-8.26]
News nit: you probably want to remove that stray "when": s/when //
Fix looks fine. Thanks!