Re: new snapshot available: coreutils-8.27.99-3ebdc3

[Pádraig Brady]

On 29/08/17 03:23, Erik Auerswald wrote:
> Hi,
> 
> On Tue, Aug 29, 2017 at 01:49:17AM -0700, Pádraig Brady wrote:
>> We plan to release coreutils-8.28 towards the end of this week,
>> so any testing you can do on various different systems between now and then
>> would be most welcome.
>> [...]
>>   tar -xf coreutils-ss.tar.xz
>>   cd coreutils-8.27.99-3ebdc3/
>>   ./configure && make check VERBOSE=yes
> 
> I have tested the snapshot on a Ubuntu LTS 14.04 x86_64 notebook following the
> above procedure. One FAIL was reported:
> 
> ----8<----
> FAIL: tests/df/df-symlink
> =========================
> 
> ++ initial_cwd_=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3
> +++ testdir_prefix_
> +++ printf gt
> ++ pfx_=gt
> +++ mktempd_ /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3 
> gt-df-symlink.sh.XXXX
> +++ case $# in
> +++ destdir_=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3
> +++ template_=gt-df-symlink.sh.XXXX
> +++ MAX_TRIES_=4
> +++ case $destdir_ in
> +++ destdir_slash_=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/
> +++ case $template_ in
> ++++ unset TMPDIR
> +++ d=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> +++ case $d in
> +++ :
> +++ test -d 
> /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> ++++ ls -dgo 
> /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> +++ perms='drwx------ 2 4096 Aug 29 12:09 
> /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG'
> +++ case $perms in
> +++ :
> +++ echo /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> +++ return
> ++ 
> test_dir_=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> ++ cd /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> ++ gl_init_sh_nl_='
> '
> ++ IFS='        
> '
> ++ for sig_ in 1 2 3 13 15
> +++ expr 1 + 128
> ++ eval 'trap '\''Exit 129'\'' 1'
> +++ trap 'Exit 129' 1
> ++ for sig_ in 1 2 3 13 15
> +++ expr 2 + 128
> ++ eval 'trap '\''Exit 130'\'' 2'
> +++ trap 'Exit 130' 2
> ++ for sig_ in 1 2 3 13 15
> +++ expr 3 + 128
> ++ eval 'trap '\''Exit 131'\'' 3'
> +++ trap 'Exit 131' 3
> ++ for sig_ in 1 2 3 13 15
> +++ expr 13 + 128
> ++ eval 'trap '\''Exit 141'\'' 13'
> +++ trap 'Exit 141' 13
> ++ for sig_ in 1 2 3 13 15
> +++ expr 15 + 128
> ++ eval 'trap '\''Exit 143'\'' 15'
> +++ trap 'Exit 143' 15
> ++ trap remove_tmp_ 0
> + path_prepend_ ./src
> + test 1 '!=' 0
> + path_dir_=./src
> + case $path_dir_ in
> + abs_path_dir_=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/./src
> + case $abs_path_dir_ in
> + 
> PATH=/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/./src:/home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/src:/home/auerswald/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
> + create_exe_shims_ /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/./src
> + case $EXEEXT in
> + return 0
> + shift
> + test 0 '!=' 0
> + export PATH
> + print_ver_ df
> + require_built_ df
> + skip_=no
> + for i in '"$@"'
> + case " $built_programs " in
> + test no = yes
> + test yes = yes
> + local i
> + for i in '$*'
> + env df --version
> df (GNU coreutils) 8.27.99-3ebdc3
> Copyright (C) 2017 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by Torbjorn Granlund, David MacKenzie, and Paul Eggert.
> ++ df --out=source .
> ++ tail -n1
> + disk=/home/auerswald/.Private
> + ln -s /home/auerswald/.Private symlink
> + df --out=source,target /home/auerswald/.Private
> + df --out=source,target symlink
> + compare exp out
> + compare_dev_null_ exp out
> + test 2 = 2
> + test xexp = x/dev/null
> + test xout = x/dev/null
> + return 2
> + case $? in
> + compare_ exp out
> + diff -u exp out
> ++ df --output=source
> ++ wc -l
> ++ grep -F /home/auerswald/.Private
> + test 1 = 1
> + df --out=source,target .
> + compare exp out
> + compare_dev_null_ exp out
> + test 2 = 2
> + test xexp = x/dev/null
> + test xout = x/dev/null
> + return 2
> + case $? in
> + compare_ exp out
> + diff -u exp out
> --- exp 2017-08-29 12:09:55.555199500 +0200
> +++ out 2017-08-29 12:09:55.563199639 +0200
> @@ -1,2 +1,2 @@
> -Filesystem     Mounted on
> -/dev/sda5      /
> +Filesystem               Mounted on
> +/home/auerswald/.Private /home/auerswald
> + fail=1
> + test 1 = 1
> + dump_mount_list_
> + cat /proc/self/mountinfo
> 17 22 0:15 / /sys rw,nosuid,nodev,noexec,relatime - sysfs sysfs rw
> 18 22 0:3 / /proc rw,nosuid,nodev,noexec,relatime - proc proc rw
> 19 22 0:5 / /dev rw,relatime - devtmpfs udev 
> rw,size=1975032k,nr_inodes=493758,mode=755
> 20 19 0:12 / /dev/pts rw,nosuid,noexec,relatime - devpts devpts 
> rw,gid=5,mode=620,ptmxmode=000
> 21 22 0:16 / /run rw,nosuid,noexec,relatime - tmpfs tmpfs 
> rw,size=398136k,mode=755
> 22 1 8:5 / / rw,relatime - ext4 /dev/sda5 rw,errors=remount-ro,data=ordered
> 23 17 0:17 / /sys/fs/cgroup rw,relatime - tmpfs none rw,size=4k,mode=755
> 24 17 0:18 / /sys/fs/fuse/connections rw,relatime - fusectl none rw
> 25 17 0:6 / /sys/kernel/debug rw,relatime - debugfs none rw
> 26 17 0:10 / /sys/kernel/security rw,relatime - securityfs none rw
> 27 21 0:19 / /run/lock rw,nosuid,nodev,noexec,relatime - tmpfs none 
> rw,size=5120k
> 28 21 0:20 / /run/shm rw,nosuid,nodev,relatime - tmpfs none rw
> 29 21 0:21 / /run/user rw,nosuid,nodev,noexec,relatime - tmpfs none 
> rw,size=102400k,mode=755
> 31 17 0:23 / /sys/fs/pstore rw,relatime - pstore none rw
> 30 23 0:22 / /sys/fs/cgroup/cpuset rw,relatime - cgroup cgroup rw,cpuset
> 32 23 0:24 / /sys/fs/cgroup/cpu rw,relatime - cgroup cgroup rw,cpu
> 33 23 0:25 / /sys/fs/cgroup/cpuacct rw,relatime - cgroup cgroup rw,cpuacct
> 34 23 0:26 / /sys/fs/cgroup/memory rw,relatime - cgroup cgroup rw,memory
> 35 23 0:27 / /sys/fs/cgroup/devices rw,relatime - cgroup cgroup rw,devices
> 36 23 0:28 / /sys/fs/cgroup/freezer rw,relatime - cgroup cgroup rw,freezer
> 37 23 0:29 / /sys/fs/cgroup/blkio rw,relatime - cgroup cgroup rw,blkio
> 38 23 0:30 / /sys/fs/cgroup/perf_event rw,relatime - cgroup cgroup 
> rw,perf_event
> 39 23 0:31 / /sys/fs/cgroup/hugetlb rw,relatime - cgroup cgroup rw,hugetlb
> 41 18 0:33 / /proc/sys/fs/binfmt_misc rw,nosuid,nodev,noexec,relatime - 
> binfmt_misc binfmt_misc rw
> 40 21 0:32 / /run/rpc_pipefs rw,relatime - rpc_pipefs rpc_pipefs rw
> 43 23 0:34 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup 
> systemd rw,name=systemd
> 44 22 0:35 / /home/auerswald rw,nosuid,nodev,relatime - ecryptfs 
> /home/auerswald/.Private 
> rw,ecryptfs_fnek_sig=6ddd8201f948e7eb,ecryptfs_sig=b85d619f28625ea9,ecryptfs_cipher=aes,ecryptfs_key_bytes=16,ecryptfs_unlink_sigs
> 45 29 0:36 / /run/user/1000/gvfs rw,nosuid,nodev,relatime - fuse.gvfsd-fuse 
> gvfsd-fuse rw,user_id=1000,group_id=1000
> + Exit 1
> + set +e
> + exit 1
> + exit 1
> + remove_tmp_
> + __st=1
> + cleanup_
> + :
> + test '' = yes
> + cd /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3
> + chmod -R u+rwx 
> /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> + rm -rf /home/auerswald/tmp/c/coreutils-8.27.99-3ebdc3/gt-df-symlink.sh.AJTG
> + exit 1
> FAIL tests/df/df-symlink.sh (exit status: 1)
> ----8<----

There was a patch to df in this release, though I don't think it's related:
https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=a19ff5d8
It's a one line patch worth testing reverted, but probably not the cause.

I suspect it's the test not handling overmounts like this correctly.
Particularly for you the difference is:

 $ df --out=source,target /home/auerswald/.Private
 Filesystem     Mounted on
 /dev/sda5      /

 df --out=source,target '.'
 Filesystem               Mounted on
 /home/auerswald/.Private /home/auerswald

thanks for testing,
Pádraig