coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test: avoid FP in chroot-credentials.sh for different group


From: Jim Meyering
Subject: Re: [PATCH] test: avoid FP in chroot-credentials.sh for different group list order
Date: Sun, 21 Oct 2018 15:20:21 +0300

On Sat, Oct 20, 2018 at 8:22 PM Bernhard Voelker
<address@hidden> wrote:
> On 10/20/18 11:32 AM, Jim Meyering wrote:
> > If you adjust your function to be:
> >
> >   num_sort() { tr -s ' ' '\n' |sort -n; }
> >
> > then you can make less invasive changes like this:
> >
> > test "$(chroot --userspec=$NON_ROOT_USERNAME / id -G|num_sort)" = \
> >      "$(id -G $NON_ROOT_USERNAME|num_sort)" || fail=1
>
> Fair enough.  My intention was to catch more errors (while they are
> swallowed by the pipe) vs. yours is the smaller change, indeed.
> New version attached, pushing soon.

Thank you. That looks fine.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]