[Cvs-cvs] ccvs/src ChangeLog client.c import.c lock.c log... [cvs1-11-x-branch]

[Larry Jones]

CVSROOT:        /cvsroot/cvs
Module name:    ccvs
Branch:         cvs1-11-x-branch
Changes by:     Larry Jones <scjones>   07/12/19 20:44:17

Modified files:
        src            : ChangeLog client.c import.c lock.c login.c 
                         mkmodules.c modules.c rcs.c server.c 

Log message:
        * client.c, import.c, lock.c, login.c, mkmodules.c, modules.c,
        rcs.c, server.c: Fix gcc -Wall warnings.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/ChangeLog?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.2336.2.495&r2=1.2336.2.496
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/client.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.318.4.45&r2=1.318.4.46
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/import.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.133.4.19&r2=1.133.4.20
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/lock.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.59.4.20&r2=1.59.4.21
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/login.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.70.4.9&r2=1.70.4.10
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/mkmodules.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.66.6.12&r2=1.66.6.13
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/modules.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.63.6.13&r2=1.63.6.14
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/rcs.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.262.4.63&r2=1.262.4.64
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/server.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.284.2.55&r2=1.284.2.56

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/ChangeLog,v
retrieving revision 1.2336.2.495
retrieving revision 1.2336.2.496
diff -u -b -r1.2336.2.495 -r1.2336.2.496
--- ChangeLog   17 Dec 2007 01:32:19 -0000      1.2336.2.495
+++ ChangeLog   19 Dec 2007 20:44:15 -0000      1.2336.2.496
@@ -1,3 +1,8 @@
+2007-12-19  Larry Jones  <address@hidden>
+
+       * client.c, import.c, lock.c, login.c, mkmodules.c, modules.c,
+       rcs.c, server.c: Fix gcc -Wall warnings.
+
 2007-12-16  Larry Jones  <address@hidden>
 
        * rcs.c (HAVE_MMAP): Fall back to stdio if mmap fails.

Index: client.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/client.c,v
retrieving revision 1.318.4.45
retrieving revision 1.318.4.46
diff -u -b -r1.318.4.45 -r1.318.4.46
--- client.c    19 Jun 2007 02:56:12 -0000      1.318.4.45
+++ client.c    19 Dec 2007 20:44:15 -0000      1.318.4.46
@@ -3842,7 +3842,7 @@
     int do_gssapi;
     struct hostent *hostinfo;
 {
-    char *username;                    /* the username we use to connect */
+    char *username = "";               /* the username we use to connect */
     char no_passwd = 0;                        /* gets set if no password 
found */
 
     /* FIXME!!!!!!!!!!!!!!!!!!

Index: import.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/import.c,v
retrieving revision 1.133.4.19
retrieving revision 1.133.4.20
diff -u -b -r1.133.4.19 -r1.133.4.20
--- import.c    15 Jun 2007 20:55:03 -0000      1.133.4.19
+++ import.c    19 Dec 2007 20:44:16 -0000      1.133.4.20
@@ -164,7 +164,7 @@
      */
     /* for each "CVS" in path... */
     cp = argv[0];
-    while (cp = strstr(cp, "CVS"))
+    while ((cp = strstr(cp, "CVS")) != NULL)
     {
        if ( /* /^CVS/ OR m#/CVS#... */
            (cp == argv[0] || ISDIRSEP(*(cp-1)))

Index: lock.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/lock.c,v
retrieving revision 1.59.4.20
retrieving revision 1.59.4.21
diff -u -b -r1.59.4.20 -r1.59.4.21
--- lock.c      26 May 2006 16:25:25 -0000      1.59.4.20
+++ lock.c      19 Dec 2007 20:44:16 -0000      1.59.4.21
@@ -173,7 +173,7 @@
     const char *p;
     char *q;
     const char *short_repos;
-    mode_t save_umask;
+    mode_t save_umask = 0;
     int saved_umask = 0;
 
     if (lock_dir == NULL)

Index: login.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/login.c,v
retrieving revision 1.70.4.9
retrieving revision 1.70.4.10
diff -u -b -r1.70.4.9 -r1.70.4.10
--- login.c     26 Jul 2006 07:22:00 -0000      1.70.4.9
+++ login.c     19 Dec 2007 20:44:16 -0000      1.70.4.10
@@ -115,20 +115,20 @@
     {
        /* Yes: slurp '^/\d+\D' and parse the rest of the line according to 
version number */
        char *q;
-       unsigned long int entry_version;
+       unsigned long int entry_version = 0;
 
        if (isspace(*(linebuf + 1)))
+       {
            /* special case since strtoul ignores leading white space */
            q = linebuf + 1;
+       }
        else
+       {
            entry_version = strtoul (linebuf + 1, &q, 10);
-
-       if (q == linebuf + 1)
-           /* no valid digits found by strtoul */
-           entry_version = 0;
-       else
+           if (q != linebuf + 1)
            /* assume a delimiting seperator */
            q++;
+       }
 
        switch (entry_version)
        {

Index: mkmodules.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/mkmodules.c,v
retrieving revision 1.66.6.12
retrieving revision 1.66.6.13
diff -u -b -r1.66.6.12 -r1.66.6.13
--- mkmodules.c 27 Aug 2007 02:26:52 -0000      1.66.6.12
+++ mkmodules.c 19 Dec 2007 20:44:16 -0000      1.66.6.13
@@ -858,8 +858,6 @@
 
     for (;;)
     {
-       char *p;
-
        if (isdir (cp))
        {
            int foundit;

Index: modules.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/modules.c,v
retrieving revision 1.63.6.13
retrieving revision 1.63.6.14
diff -u -b -r1.63.6.13 -r1.63.6.14
--- modules.c   7 Jun 2006 06:56:05 -0000       1.63.6.13
+++ modules.c   19 Dec 2007 20:44:16 -0000      1.63.6.14
@@ -129,7 +129,7 @@
     char *line;
     int modargc;
     int xmodargc;
-    char **modargv;
+    char **modargv = NULL;
     char **xmodargv = NULL;
     /* Found entry from modules file, including options and such.  */
     char *value = NULL;

Index: rcs.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/rcs.c,v
retrieving revision 1.262.4.63
retrieving revision 1.262.4.64
diff -u -b -r1.262.4.63 -r1.262.4.64
--- rcs.c       17 Dec 2007 01:32:20 -0000      1.262.4.63
+++ rcs.c       19 Dec 2007 20:44:16 -0000      1.262.4.64
@@ -4140,7 +4140,8 @@
 {
     int free_rev = 0;
     enum kflag expand;
-    FILE *fp, *ofp;
+    FILE *fp;
+    FILE *ofp = NULL;
     struct stat sb;
     struct rcsbuffer rcsbuf;
     char *key;

Index: server.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/server.c,v
retrieving revision 1.284.2.55
retrieving revision 1.284.2.56
diff -u -b -r1.284.2.55 -r1.284.2.56
--- server.c    22 Aug 2007 21:33:52 -0000      1.284.2.55
+++ server.c    19 Dec 2007 20:44:17 -0000      1.284.2.56
@@ -2767,7 +2767,7 @@
 
     int dev_null_fd = -1;
 
-    int errs;
+    int errs = 0;
 
     command_pid = -1;
     stdout_pipe[0] = -1;