dchub-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Dchub-dev] [patch #2270] [Patch #2270] implemented afk/seen/msg as plug


From: noreply
Subject: [Dchub-dev] [patch #2270] [Patch #2270] implemented afk/seen/msg as plugin
Date: Fri, 21 Nov 2003 14:07:16 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686) Gecko/20030428 Galeon/1.3.3

Patch #2270 has been updated. 

Project: 
Category: Plugins
Status: Closed
Summary: implemented afk/seen/msg as plugin

Follow-Ups:

Date: Sun 11/09/2003 at 14:24
By: hhgoth

Comment:
removed following commands from hubsoft:
+afk,+back,+seen,-users,+msg,+clearmsg
and implemented them as plugins with some additional commands
...afk_list.c,afk_list.h,msg_list.c,msg_list.h,seen_list.c,seen_list.h can be 
removed compleatly

added 2 commands to hub_cmd.c:
-pluginstart pluginname
-pluginstop pluginname

changed usertype for plugins defaulting to -1 to make it possible to differ 
regged users from unregged users
added successful-reply if pluginstop succeeds
-------------------------------------------------------

Date: Thu 11/13/2003 at 14:58
By: hhgoth

Comment:
please tell me if you want to use the plugins.

...I fixed many bugs inside encountered in my online-hub

so if you think it's useful I send you the rewritten plugins separately as a 
new patch


-------------------------------------------------------

Date: Sun 11/16/2003 at 15:51
By: hhgoth

Comment:
plugins partially rewritten
-------------------------------------------------------

Date: Mon 11/17/2003 at 18:51
By: ericprev

Comment:
I think the plugin usage is a good idea, I will integrate your patch next 
week-end (I will have no time before).
-------------------------------------------------------

Date: Fri 11/21/2003 at 19:56
By: ericprev

Comment:
I have integrated your patch. I have fixed some errors but some are still here 
(see the warning messages on compilation). I have fixed numerous memory leaks 
(when you use strdup (you seem to really like it), don't forget to free the 
duplicated string). I also have encountered a buffer overflow (off by 1). I 
have also optimized some parts dealing with chat to make them faster and easier 
to read. I have also optimized the code where you manipulate date (take a look, 
this part of printf is not well known). But I am very proud of my optimization 
of plg_add_slots where I have replaced more than 35 lines with only one command 
:) and moreover, it is readable...



The patch is applied but to make it fully workable, I still should remove the 
same commands from the dchub core. I will do this tomorrow morning.
-------------------------------------------------------

Date: Fri 11/21/2003 at 20:07
By: ericprev

Comment:
by the way, I have not seen any patch on hub_cmd to add -pluginstart and 
-pluginstop
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.nongnu.org/patch/?func=detailpatch&patch_id=2270&group_id=3963

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]