Re: Memo: Re: More build problems with DDD on HPUX using aCC

[Arnaud Desitter]

Hi,

address@hidden wrote:

> >> I rebuilt DDD from scratch on HPUX 10.20B today and got a few fatal link
> errors.
> >> It couldn't find the symbols static_sep and static_r. This turns out to be 
> >> a
> >> weirdness
> >> of the aCC compiler for which I have a workaround.
> >>
> >
> >Did you have a look at PROBLEMS in the ddd distribution ?
> >
> ><QUOTE>
> >    * IMPORTANT: I just installed the latest aCC patch, released
> >      around yesterday (2000/02/02)!!! Its number is PHSS_20959.
> >      Without it, linking failed with
> >        /usr/ccs/bin/ld: Unsatisfied symbols:
> >       static_r (data)
> ></QUOTE>
> 
> No I didn't. I should have. However, the fixes I have will enable DDD
> to be built with systems that do not have this patch. I cannot get
> this patch easily for the system I am using right now.

Ok. The patch below summarizes Andrew's proposal. 
The code builds properly in a variety if Unix platforms.

Regards,
Arnaud


Index: charsets.h
===================================================================
RCS file: /cvsroot/ddd/ddd/ddd/charsets.h,v
retrieving revision 1.12
diff -u -r1.12 charsets.h
--- charsets.h  2000/12/11 12:21:48     1.12
+++ charsets.h  2001/10/03 13:45:08
@@ -122,10 +122,10 @@
 #if XmVERSION == 1 && XmREVISION <= 1
 inline MString cr() { return rm("\n"); }
 #else
+const XmString charsets_sep = XmStringSeparatorCreate();
 inline MString cr() 
 {
-    static XmString sep = XmStringSeparatorCreate();
-    return MString(sep, true);
+    return MString(charsets_sep, true);
 }
 #endif
 
Index: HintGraphN.h
===================================================================
RCS file: /cvsroot/ddd/ddd/ddd/HintGraphN.h,v
retrieving revision 1.14
diff -u -r1.14 HintGraphN.h
--- HintGraphN.h        1999/08/19 11:27:35     1.14
+++ HintGraphN.h        2001/10/03 13:45:08
@@ -49,6 +49,11 @@
        RegionGraphNode(node)
     {}
 
+#if !HAVE_MUTABLE
+#else
+    mutable BoxRegion r_;
+#endif
+
 public:
     // Constructor
     HintGraphNode(const BoxPoint& initialPos = BoxPoint()):
@@ -75,11 +80,12 @@
 
     virtual const BoxRegion& sensitiveRegion(const GraphGC& gc) const
     {
-       static BoxRegion r;
-
+#if !HAVE_MUTABLE
+       static BoxRegion r_;
+#endif
        // return a size-pixel area around the current position
-       r = BoxRegion(pos() - gc.hintSize / 2, gc.hintSize);
-       return r;
+       r_ = BoxRegion(pos() - gc.hintSize / 2, gc.hintSize);
+       return r_;
     }
 
     // Print

_____________________________________________________________________
This message has been checked for all known viruses by Star Internet
delivered through the MessageLabs Virus Scanning Service. For further
information visit http://www.star.net.uk/stats.asp or alternatively call
Star Internet for details on the Virus Scanning Service.