Re: [Denemo-devel] Re: Keybinding modifications

[Richard Shann]

On Mon, 2008-06-09 at 00:47 +0200, Jean-René Reinhard wrote:
> Le Sun, Jun 08, 2008 at 09:50:24PM +0100, Richard Shann écrivait:
> > 
> > On Sun, 2008-06-08 at 20:02 +0200, Jean-René Reinhard wrote:
> > > Hi,
> > > 
> > > You can pull my code using :
> > > git clone git://81.57.242.141/denemo.git <destination directory>
> > > 
> > > It's probably best to use a new directory as a destination.
> > > You can then inspect the code, and probably merge from one repos to 
> > > another on your computer (I hope this is a valid method).
> > This is great news - Denemo really needed someone who could hack this
> > stuff.
> > Your code came down just fine. I could not compile because GDK_META_MASK
> > and friends were not defined (I am on Debian which has 2.8.20-7 as
> > latest version. I hacked in the values and got it to compile. Then it
> > would not link because gtk_widget_get_accel is not defined. This is new
> > in gtk 2.10, so that could be a more of a problem - I guess this will be
> > a problem for users (not just builders) as well, until 2.10 becomes more
> > available. Are there workarounds for these?
> 
> I'm not sure. I don't think the last commit uses gtk_widget_get_accel, but I
> really don't think gtk 2.10 availability is an issue. 2.12 is already in
> testing. As denemo 0.78 is not going to make it in debian stable, it is not
> shoking to have a dependance on gtk 2.10. (latest versions of ubuntu, red hat
> ... already ship it)
I have a workaround for 2.8 now. Your re-work of the shortcut setting
looks really nice - a great look and feel to it. We can't abandon the
context sensitive help and shortcut settings though, as this is the only
way of navigating to a desired command and then finding out what it does
and setting a shortcut for it. I've integrated the left-click code (the
old help_and_set_accels() stuff) with your code, the setting of
shortcuts is working smoothly using your routines.
I hope to get the labels to display the first shortcut, regardless of
whether it is actually an accelerator (consider, at the moment, there is
no way to find out the key press for the menu item chord->Add note, you
would have to guess that it is a function called AddTone, as it is bound
to Return and KP_Enter, neither of which can be accelerators). It should
be possible to do this, as the load_accels parsing does parse and
display them in the current version of the program.
Thank you very much for a great piece of work.
Richard 
also (see below) I am quite happy that Makefile.ins be not versioned.
> 
> I have another remark on developpement : Makefile and Makefile.in should 
> REALLY
> be removed from git (except for the Makefile.in in po). It is really a pain 
> when
> one tweaks the compilation option to have to roll back these files in order to
> make a merge work. People getting the sources from git should be considered as
> developpers, and should be able to execute autoreconf before the first
> configure. When doing a snapshot for users, Makefile.inS can be included to 
> make
> the compilation process start with configure.
> 
> Cheers,
> Jean-René
> 
>