Re: [Denemo-devel] another fixing Warnings question

[Richard Shann]

Yes, this killed the MIDI filters. I have put a fix for the warning
while getting the masking-off of the channel right.
Richard

On Sat, 2011-02-12 at 09:53 +0000, Richard Shann wrote:
> - gchar *buf = &midi;
> 
> - *buf &=0xF0;//do not return channel info
> 
> + midi &=0xF0;//do not return channel info 
> 
> This looks like a dangerous change too. Have you tested it on at least
> one system? It is altering other bits that I would be worrying about.
> 
> Richard
> 
> from 
> diff --git a/src/view.c b/src/view.c
> 
> 
> index 9af67a6..c655ba2 100644 (file)
> 
> 
> --- a/src/view.c
> 
> +++ b/src/view.c
> 
> @@ -2658,8 +2658,7 @@ SCM scheme_get_midi(void) {
> 
>   gboolean success = intercept_midi_event(&midi);
> 
>   if(!success)
> 
>     midi = 0;/* scripts should detect this impossible value and take
> action */
> 
> - gchar *buf = &midi;
> 
> - *buf &=0xF0;//do not return channel info
> 
> + midi &=0xF0;//do not return channel info
> 
>   SCM scm = scm_int2num (midi);
> 
>   return  scm;
> 
>  }
> 
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/denemo-devel