denemo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Denemo-devel] Separating Evince build (was Re: Command Manager)


From: Richard Shann
Subject: Re: [Denemo-devel] Separating Evince build (was Re: Command Manager)
Date: Fri, 07 Jun 2013 14:18:40 +0100

On Fri, 2013-06-07 at 11:51 +0200, Éloi Rivard wrote:
> Do you mean replace calls to #ifdef USE_EVINCE by #ifndef
> DONT_USE_EVINCE so the default behavior would be to use evince? That
> sounds a good idea.

yes, sorry I didn't make that clear by changing the name of the define
as you have done. 
In mentioning it I was really making a general point, that it is a safer
way to change the code. It still has to be gotten working, although we
won't care if it is impossible to build for mingw without evince as this
is purely a ploy to allow you to test build part of the code on your
platform. In general you will find occasional bits of code surrounded by
#ifdef SOMETHING, where without some special effort on the part of the
builder the SOMETHING will never be defined, and that is a useful way of
keeping bits of code alive that some people will find useful
occasionally. (There is code to playback a half-speed for example, that
is left like this, and something for checking if the displayhelper()
call is really needed).

Richard





reply via email to

[Prev in Thread] Current Thread [Next in Thread]