diffutils-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Diffutils-devel] FYI: test fixes


From: Jim Meyering
Subject: [Diffutils-devel] FYI: test fixes
Date: Sun, 14 Jan 2018 17:17:34 -0800

FYI, I noticed an old patch (don't recall for which type of system it
was required), but pushed it anyway.  Many other *utils tests use
this same pattern:
(and now, as I look at the patch again, I see I did it right in
the commit log message, but omitted necessary double quotes in
the actual test -- just fixed with the following patch below)

From: Jim Meyering <address@hidden>
Date: Sat, 6 Jan 2018 16:24:10 -0800
Subject: [PATCH] tests: port tests/colors to some env-munging shell

* tests/colors: Also set PATH="$PATH" in env invocation.
---
 tests/colors | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/colors b/tests/colors
index 9c7021c..3215990 100755
--- a/tests/colors
+++ b/tests/colors
@@ -85,7 +85,8 @@ returns_ 1 diff --color=auto a b > out || fail=1
 gen_exp_default > exp || framework_failure_
 compare exp out || fail=1

-returns_ 1 env TERM=dumb diff ---presume-output-tty --color=auto a b > out \
+returns_ 1 env PATH=$PATH TERM=dumb \
+         diff ---presume-output-tty --color=auto a b > out \
   || fail=1
 gen_exp_default > exp || framework_failure_
 compare exp out || fail=1
--
2.13.5

From: Jim Meyering <address@hidden>
Date: Sun, 14 Jan 2018 17:16:50 -0800
Subject: [PATCH] tests: fix quoting error in previous change

* tests/colors: Double-quote $PATH.
---
 tests/colors | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/colors b/tests/colors
index 3215990..f0f6246 100755
--- a/tests/colors
+++ b/tests/colors
@@ -85,7 +85,7 @@ returns_ 1 diff --color=auto a b > out || fail=1
 gen_exp_default > exp || framework_failure_
 compare exp out || fail=1

-returns_ 1 env PATH=$PATH TERM=dumb \
+returns_ 1 env PATH="$PATH" TERM=dumb \
          diff ---presume-output-tty --color=auto a b > out \
   || fail=1
 gen_exp_default > exp || framework_failure_
--
2.13.5



reply via email to

[Prev in Thread] Current Thread [Next in Thread]