[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Discuss-gnuradio] External modules include path / namespace
From: |
Sylvain Munaut |
Subject: |
Re: [Discuss-gnuradio] External modules include path / namespace |
Date: |
Sun, 2 Jun 2013 16:28:33 +0200 |
Hi Martin,
>> include: $prefix/include/gnuradio/module_name/
>> namespace: gr::module_name::
>> python: $prefix/lib/site-package/gnuradio/module_name/
>>
>> This would also make external modules that much closer to internal
>> ones and further reduce the difference between in-tree / out-of-tree
>
> Just pointing out that oot-modules have always been a bit different,
> e.g. import MODULE vs. from gnuradio import MODULE. Also, I don't mind
> having a dedicated folder for core gnuradio stuff.
> I agree making the folder structures for in- and out-tree modules more
> similar is good, though. So, just some thoughts here, perhaps we'll talk
> about this this week.
I don't mind having a namespace for core stuff either but then maybe
it should have like gnuradio.ext.module_name or something and make it
coherent between include/c++ namespace/python.
Else you end up having to include some "gnuradio marker" in the module
name to make sure it doesn't clash with general python stuff or
general include stuff.
I actually only realized that oot were still not under some "gnuradio"
separate path when converting a module this weekend and since I guess
a lot of OOT module are going to get ported soon, now would be the
right time.
Cheers,
Sylvain