Re: [Discuss-gnuradio] coding bug in gr-channels/lib/flat_fader_impl.cc

[Tom Rondeau]

On Wed, Apr 23, 2014 at 11:57 PM, qin 1921 <address@hidden> wrote:

I believe there is a bug in file gr-channels/lib/flat_fader_impl.cc, line 67

according to Eq.4 of paper "Improved Models for the Generation of Multiple Uncorrelated Rayleigh Fading Waveforms" published on IEEE COMMUNICATIONS LETTERS, VOL. 6, NO. 6, JUNE 2002, 

that line should be changed from:

         float alpha_n = (2*M_PI*n - M_PI + d_theta)/4*d_N;

to:

       

        float alpha_n = (2*M_PI*n - M_PI + d_theta)/(4*d_N);

Thanks. Yeah, I think we're all in agreement on that. We'll fix this today.

This is simple enough for us to handle, but next time, it would be really helpful to us if you would either create an Issue on gnuradio.org or send us a pull request with the patch through github.

Thanks!

Tom