Re: [Discuss-gnuradio] gr-modtool overhaul: Proposal draft

[swapnil negi]

Hello everyone, I have incorporated the changes mentioned by Nicolas. 

Regarding GitLab profile: As per my group's policy, the code has not been made open source. Hence, due to the copyright issues, the code cannot be published in the proposal. 

Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf

Code Link: https://github.com/swap-nil7/GSoC-Proposal

Regards,

Swapnil Negi

Indian Institute of Technology Roorkee

On Mon, Mar 26, 2018 at 6:41 PM, Nicolas Cuervo <address@hidden> wrote:

Hello Swapnil,

thanks for updating your draft! I'm really excited about your application. Please don't forget to officially apply and upload your proposal through the program website.

I have very, very small comments in regard of code practices,  

• Keep in mind the coding guidelines in all your code snippets. 
• Having the functional programming as an objective, keep in mind the correct syntax is used in your functions and methods. For example: the __import__() function used in your plugin loader will work just fine, but this usage is recommended for the interpreter. For implementations as the one you are proposing, import_module() should be used (unless you are expecting to load a package). 
• Your string formatting uses the old convention. I suggest having a look at 'str'.format()

Additionally, you mention in your background that you work regularly in GitLab, but you shared your Github profile instead. Do you have code in there that is not in your Github profile? If so, would you mind adding a link to your GitLab profile?

All in all, I think that your proposal is well structured, and the examples that you provide on how to deal with the problem at hand are on point. My comments are being very picky ;) but that's because the rest of your proposal seems ready! Again, dont forget to officially apply and upload your proposal.

Cheers,

- Nicolas

On Sun, Mar 25, 2018 at 10:53 PM, swapnil negi <address@hidden> wrote:

Hello everyone, 

I have incorporated all the mentioned improvements to the best of my knowledge. Please review the *almost final* draft of the proposal.

Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf

Code Link: https://github.com/swap-nil7/GSoC-Proposal

Thank you!

Regards,

Swapnil Negi

Indian Institute of Technology Roorkee

On Sun, Mar 25, 2018 at 4:55 PM, swapnil negi <address@hidden> wrote:

Hello everyone,

Thanks for the detailed review.

I have made changes to my proposal to incorporate review/merge cycle, build Python API for the modtool, briefly explain the UI enhancements and fix typos.

I am still quite unsure about the automated testing part. But as of now, thorough testing will be done locally. 

Please review the updated version of my proposal.

Thanks! :)

Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf

Code Link: https://github.com/swap-nil7/GSoC-Proposal

On Tue, Mar 20, 2018 at 12:33 AM, swapnil negi <address@hidden> wrote:

Hello everyone! 

I have uploaded my proposal to the GitHub pages. So, please review and provide me suggestions to improve the same.

Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf

Code Link: https://github.com/swap-nil7/GSoC-Proposal

Thank You!

Regards,

Swapnil Negi

Indian Institute of Technology Roorkee

India

On Sat, Mar 17, 2018 at 3:09 AM, swapnil negi <address@hidden> wrote:

Hi Nicoloas!

Thanks for your valuable response.

Regarding Python compatibility - I will work upon version independent compatibility using information from the following links:

Link[1] Link[2] 

Regarding specific milestones - I have now listed the work that can be assessed after the completion of various phases.

Regarding CV: I have removed the section of such personal details from the CV as well as proposal.

Cheers,

Swapnil Negi 

On Fri, Mar 16, 2018 at 5:45 PM, Nicolas Cuervo <address@hidden> wrote:

Hello Swapnil Negi,

Thank you for your proposal! This project has been in the pipeline for long and I'm very excited to see your interest in working on it. I have very few comments for now, but the discussion can definitely continue open:

So the timeline that you are proposing is:
1) Python3 Compatible

2) Implement Plugin Architecture

3) Restructure code in favor of functional behavior

4) work on UI if time allows

And I agree with this timeline, as it puts core focus on the architectural overhaul without disregarding other details aside. 

• If I understand correctly, your first task to tackle is the Py3k compatibility, which is great. This is definitely something that needs to be done, as there is a continuous effort on making the whole GNURadio Python3 compatible. But Python2 is not EOL for little less than 2 years more, so continuous compatibility is something that has to be kept in mind. Let's take your proposed code for raiseException, whose implementation won't work on Python2. There are ways to ensure compatibility (using wrappers from 'six' for example, which adds a dependency - which can be discussed) 
  I, however, see that the Python3 branch from GNU Radio already implements the syntax that you are proposing, so I might being just too picky on this. I expect comments on the matter from the list.
  
  
• I see that you have put efforts in contributing already to the project by fixing some issues on the tool, and there is hardly a better way to get used to it and contribute to the project. No comment here apart from saying that we do appreciate you took that path as it puts you into context and improves the project. Win-Win!
  
  
• I would work on the format of the proposal as well to help you make a better impression and increases your chances of this being accepted. In your timeline, be sure to explicitly say what deliverable can be expected when. It's good to know when you are going to start working on something, but it is also important to know when you are expected to have it finished. Words like "Milestone" or even "Deliverable" might make this clear, maybe around the evaluation dates. 
  
  
• I see that you included your CV, which is nice to have, but do you _really_ want your personal data (like phone and address) out in the open? 
  
  

I might come back with more comments, but for now this is looking promising!

Cheers,

- Nicolas

On Fri, Mar 16, 2018 at 3:57 AM, swapnil negi <address@hidden> wrote:

Hello everyone, I am Swapnil Negi, an undergraduate from Indian Institute of Technology Roorkee, India. I wish to contribute to the project idea "gr-modtool overhaul". Here is the draft of my proposal. Kindly review it and give your valuable suggestins.

This is something that I expected from the discussion. If there's something that I am missing out, please do inform me.

Thanks!

Regards, Swapnil Negi

_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio