[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Another NSDocument patch
From: |
Wolfgang Lux |
Subject: |
Re: Another NSDocument patch |
Date: |
Wed, 7 Mar 2007 19:03:58 +0100 |
Fred Kiefer wrote:
Commited.
Thanks. However, I just noticed that my previous NSDocument patch
was committed only partially (in r24758). After syncing with the
trunk, the following diff still remains in my local copy.
Index: Source/NSDocument.m
===================================================================
--- Source/NSDocument.m (revision 24800)
+++ Source/NSDocument.m (working copy)
@@ -1036,6 +1036,7 @@
NSDocumentController *controller;
NSSavePanel *savePanel = [NSSavePanel savePanel];
+ ASSIGN(_save_type, [self fileType]);
controller = [NSDocumentController sharedDocumentController];
displayNames = [controller _displayNamesForClass: [self class]];
Note that the document's file type is not necessarily the same as
the one used in the last save panel. However, NSDocument uses _save_type
(via the method -fileTypeFromLastRunSavePanel) in order to determine
the type of file written and will also set the document's type to
to that type after a successful save operation. Therefore, it is
important to sync this instance variable with the document's file
type (which is selected in the save panel's pop up menu).
Regards
Wolfgang