Re: focus problem

[Yen-Ju Chen]

On 8/22/07, Yen-Ju Chen <yjchenx@gmail.com> wrote:
> On 8/22/07, Yen-Ju Chen <yjchenx@gmail.com> wrote:
> > On 8/22/07, Andreas Höschler <ahoesch@smartsoft.de> wrote:
> > > Hi Yen-Ju,
> > >
> > > > As I said, the first half of the issue is that GNUstep cannot find the
> > > > focused window while it is unmapped. So it deactivates itself.
> > > > This patch transfers the focus to another window in the
> > > > same GNUstep application before it is unmapped,
> > > > therefore, fixes the problem.
> > > >
> > > > The second half of the problem is that after the unmapping,
> > > > window manager tends to actively find another window to focus on,
> > > > therefore, even GNUstep transfers the focus, it still loses it.
> > > > So there is nothing GNUstep can do about it.
> > > > It has to be fixed on window manager.
> > > >
> > > > This patch works for me, but may need to improvement.
> > >
> > > Thanks for working on this!
> > >
> > > After applying your patch I can no longer switch between applications
> > > via clicking on application windows. The clicked window is not put to
> > > foreground!? :-(
>
>   O.K. I can see why it happens. It's another racing issue. :(
>   Well, the patch may need to move to up stream.

  Here is the same patch, but apply on -gui when window is closed.
  Therefore, it will not affect the situation when window loses focus,
  but not closed (application switching).
  The idea is the same: transfer focus to another window before it
gets unmapped.
  This patch does not fix "key focus on wrong window", "window
flicking", nor "menu disappear after last document minimized".
  It only fixes the "menu disappear after last document window closed".

  Yen-Ju

>
>   Yen-Ju
>
> >
> > Do you have latest Azalea from -trunk ?
> > There are a few changes on it to match what GNUstep does.
> > I have no problem switching application by clicking on their windows.
> > But I will run it for a while to see.
> > Fixing such bug has a side-effect that it may introduce another one.  :(
> >
> > I am pretty sure that the problem is as I described.
> > But the fix may not be totally correct.
> > And it doesn't fix the loss of focus during minimization.
> > I am also not sure whether it will break on WindowMaker.
> >
> > Yen-Ju
> >
> > >
> > > Regards,
> > >
> > >    Andreas
> > >
> > >
> > >
> >
>

focus_gui_patch.diff
Description: Text Data