|
From: | Wolfgang Lux |
Subject: | Commit r29000 |
Date: | Fri, 20 Nov 2009 16:37:26 +0100 |
Hi Doug,I'm having a little problem with this patch, which made it to the trunk meanwhile thanks to Fred. The change in NSTextField's - textDidEndEditing: ensures that the text field always sends its action when editing ends and the text field is configured that way, which I think is correct. However, with your patch the text field also sends -selectText: to itself when it is first responder. This is definitely wrong in at least one case: The -textDidEndEditing: callback is called when the text field resigns first responder because the user clicked into another view. At the time when - textDidEndEditing: is called the text field is still first responder and so will incorrectly call -selectText:. Therefore I'd prefer to revert this part of your change and call -selectText: only when editing ends with either NSTabTextMovement or NSBacktabTextMovement (as before) unless your change is supposed to fix a bug in GNUstep.
Wolfgang
[Prev in Thread] | Current Thread | [Next in Thread] |