discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ANN: DBusKit 0.1


From: Andreas Schik
Subject: Re: ANN: DBusKit 0.1
Date: Tue, 17 May 2011 13:31:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10

Hello Niels,
looks very nice. Thank you.
Unfortunately, I have already come across abug in DKNotificationCenter.
The interface name for the addObserver: family of selectors is
calculated wrongly (_signalForNotificationName:). The last character is
cut off, thus signals are not passed on the observers.
Here's the patch:

Index: Source/DKNotificationCenter.m
===================================================================
--- Source/DKNotificationCenter.m       (Revision 33048)
+++ Source/DKNotificationCenter.m       (Arbeitskopie)
@@ -1362,7 +1362,7 @@
       [lock unlock];
       return nil;
     }
-    ifName = [stripped substringToIndex: (sepRange.location - 1)];
+    ifName = [stripped substringToIndex: sepRange.location];
     signalName = [stripped substringFromIndex: (sepRange.location + 1)];
     [lock unlock];
     return [self _signalWithName: signalName

Cheers,
Andreas

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]