Re: Testers wanted for MPDCon and Zipper

[Sebastian Reitenbach]

On Wednesday, February 22, 2012 15:16 CET, Riccardo Mottola 
<riccardo.mottola@libero.it> wrote:

> Hmm,
>
> I notice that the code assagines in several places NSNotFound to a
> variable of NSComparisonResult. I feel this is wrong, since it is not
> defined in the enum and the type allocated for NSComparisonResult by the
> compiler could be different of the one of NSNotFound.
> Any suggestions on how to fix this? NSComparisonResult is most probably
> signed since it starts with -1.

I think this is totally stupid, and was maybe just incidentally working before 
the NSNotFound change?
We should probably use one of the three values from the _NSComparisonResult 
enum from Foundation/NSObjCRuntime.h

Sebastian

>
> Riccardo
>
> Sebastian Reitenbach wrote:
> >
> > On Wednesday, February 22, 2012 12:01 CET, Riccardo 
> > Mottola<riccardo.mottola@libero.it>  wrote:
> >
> >> Hi,
> >>> I am not able to reproduce this behaviour here (OpenSuse 12.1, gcc 4.6,
> >>> 64bit). I get plenty of horrible compiler warnings from Zipper
> >>> (current CVS), which really should be fixed before looking deeper into
> >>> any issue with that application.
> >>> Could you please describe in detail all the steps required to
> >>> reproduce the crash?
> >>>
> >> which warnings do you get? I don't get any on OpenBSD with gcc 4.2. On
> >> NetBSD with 4.5 I get some harmless looking ones. I'll try to fix them
> >> though.
> > With clang, I also get no warnings, with gcc-4.6 it looks like this:
> >
> > gcc Archive.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/Archive.m.o
> > Archive.m: In function ‘-[Archive initWithPath:]’:

> > Archive.m:120:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > Archive.m: In function ‘-[Archive expandFiles:withPathInfo:toPath:]’:
> > Archive.m:307:2: warning: function with qualified void return type called 
> > [enabled by default]
> > Archive.m:309:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > Archive.m: In function ‘-[Archive listContents]’:
> > Archive.m:371:2: warning: function with qualified void return type called 
> > [enabled by default]
> > Archive.m: In function ‘+[Archive unarchiveExecutable]’:
> > Archive.m:394:2: warning: function with qualified void return type called 
> > [enabled by default]
> > Archive.m: In function ‘+[Archive archiveType]’:
> > Archive.m:405:2: warning: function with qualified void return type called 
> > [enabled by default]
> >
> > gcc FileInfo.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/FileInfo.m.o
> > FileInfo.m: In function ‘-[FileInfo comparePathAscending:]’:
> > FileInfo.m:145:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > FileInfo.m:172:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > FileInfo.m: In function ‘-[FileInfo compareSizeAscending:]’:
> > FileInfo.m:190:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > FileInfo.m: In function ‘-[FileInfo compareFilenameAscending:]’:
> > FileInfo.m:209:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > FileInfo.m: In function ‘-[FileInfo compareDateAscending:]’:
> > FileInfo.m:227:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> > FileInfo.m: In function ‘-[FileInfo compareRatioAscending:]’:
> > FileInfo.m:245:2: warning: overflow in implicit constant conversion 
> > [-Woverflow]
> >
> > gcc GzipArchive.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/GzipArchive.m.o
> > GzipArchive.m: In function ‘-[GzipArchive 
> > expandFiles:withPathInfo:toPath:]’:
> > GzipArchive.m:51:12: warning: variable ‘filename’ set but not used 
> > [-Wunused-but-set-variable]
> >
> > gcc NSFileManager+Custom.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/NSFileManager+Custom.m.o
> > NSFileManager+Custom.m: In function ‘-[NSFileManager(Custom) 
> > locateExecutable:]’:
> > NSFileManager+Custom.m:26:8: warning: variable ‘isScanned’ set but not used 
> > [-Wunused-but-set-variable]
> >
> > gcc TableViewDataSource.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/TableViewDataSource.m.o
> > TableViewDataSource.m: In function ‘-[TableViewDataSource 
> > tableView:willDisplayCell:forTableColumn:row:]’:
> > TableViewDataSource.m:27:9: warning: variable ‘size’ set but not used 
> > [-Wunused-but-set-variable]
> >
> > gcc ZipperDocument.m -c \
> >        -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
> > -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
> > -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN 
> > -DGSDIAGNOSE -Wno-import -g -O2 -fgnu-runtime -Wall -Wno-import 
> > -fconstant-string-class=NSConstantString -fexec-charset=UTF-8 -I. 
> > -I/root/GNUstep/Library/Headers -I/opt/gnustep/include \
> >         -o obj/Zipper.obj/ZipperDocument.m.o
> > ZipperDocument.m: In function ‘-[ZipperDocument openFile:withDefaultApp:]’:
> > ZipperDocument.m:430:12: warning: variable ‘extension’ set but not used 
> > [-Wunused-but-set-variable]
> >
> >
>