Re: [dmidecode] [PATCH] dmidecode: additions from smbios 2.6.1 spec update

[Jarod Wilson]

On Friday 28 August 2009 16:05:48 Jean Delvare wrote:
> On Fri, 28 Aug 2009 14:57:50 -0400, Jarod Wilson wrote:
> > > > > > dmidecode: additions from smbios 2.6.1 spec update
> > ...
> > > I didn't check, did you add full support for SMBIOS 2.6.1 already?
> > 
> > Yeah, I *think* I got everything. Just double-checked the changelog
> > and the processor list, everything seems to be there now.
> > 
> > > If
> > > you did, then you probably want to update the specification reference
> > > at the top of the source file.
> > 
> > Are you referring to the SUPPORTED_SMBIOS_VER define at the top of
> > dmidecode.c? If so, it looks like there's some work to do to properly
> > support version checking with the third revision level... The SMBIOS
> > structure table (section 2.1.1) doesn't seem to provide support for
> > anything more than major/minor either.
> 
> You're right about the third revision level, although I don't think
> this should be an issue in practice (when only the third revision level
> changes, there shouldn't be any incompatible changes, only
> clarifications and new enumerated values.)

Okay, good to know.

> But this isn't what I meant.
> What I was referring to was:
> 
>  * Unless specified otherwise, all references are aimed at the "System
>  * Management BIOS Reference Specification, Version 2.6" document,
>  * available from http://www.dmtf.org/standards/smbios/.
> 
> where 2.6 would become 2.6.1.

I first thought you meant something like that, but I somehow overlooked
that section and jumped on the define. Oops. :)

Committing additions momentarily...

-- 
Jarod Wilson
address@hidden