Re: [dmidecode] [Patch 0/4] dmidecode: add dmi sysfs support

[Ivan Khoronzhuk]

On 02/04/2015 04:46 PM, Anton Arapov wrote:
> Hello Ivan,
>
> I’m fine with the patchset in general. Though I don’t like moving the
> memory allocation to smbios_decode(), it dupes the code and doesn’t
> help reading. But I can live with this.

It dupes a little, but it simplifies dmi_table_dum() in the same time.

> I do not want to have an extra depenendency on libmifs too. dmidecode
> as a tool meant to be self-sufficient. We might want to get the dmifs
> implementation into dmidecode.
>
> Jean, what is your opinion here?
>
> thanks!
> Anton.
>
> On Thu, Jan 29, 2015 at 06:50:08PM +0200, Ivan Khoronzhuk wrote:
> > This series adds dmi sysfs support for dmidecode.
> > It's needed when access to /dev/mem is forbidden. In this case
> > to get needed information the dmi sysfs can be used.
> >
> > To add support of dmi sysfs the newly introduced dmifs library were
> > used - libdmifs. Currently it's situated at
> > https://git.linaro.org/people/ivan.khoronzhuk/libdmifs.git
> > The library is needed to simplify working with DMI sysfs.
> >
> > For convenience dmidecode git mirror:
> > https://git.linaro.org/people/ivan.khoronzhuk/dmidecode.git
> >
> > Ivan Khoronzhuk (4):
> >    dmidecode: use common function to get SMBIOS version
> >    dmidecode: use common function to put SMBIOS in dumpfile
> >    dmidecode: move memory map function from dmi_decode
> >    dmidecode: add dmi sysfs support
> >
> >   Makefile    |   2 +-
> >   dmidecode.c | 186 ++++++++++++++++++++++++++++++++++++++++--------------------
> >   version.h   |   2 +-
> >   3 files changed, 127 insertions(+), 63 deletions(-)
> >
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > https://lists.nongnu.org/mailman/listinfo/dmidecode-devel