Re: [dmidecode] [PATCH 2/5] dmidecode: Add enums from the SMBIOS 3.0.0 specification

[Jean Delvare]

Hi Roy,

On Tue, 21 Apr 2015 11:19:07 -0700, Roy Franz wrote:
> On Tue, Apr 21, 2015 at 2:57 AM, Jean Delvare <address@hidden> wrote:
> > Add 28 new enumerated values from the SMBIOS 3.0.0 specification (3
> > chassis types, 4 processor families, 4 processor upgrades, 13 slot
> > types and 4 memory device types.)
> > ---
> >  dmidecode.c |   46 ++++++++++++++++++++++++++++++++++++++--------
> >  1 file changed, 38 insertions(+), 8 deletions(-)
> > (...)
> > @@ -1675,7 +1686,20 @@ static const char *dmi_slot_type(u8 code
> >                 "AGP 2x",
> >                 "AGP 4x",
> >                 "PCI-X",
> > -               "AGP 8x" /* 0x13 */
> > +               "AGP 8x",
> > +               "M.2 Socket 1-DP",
> > +               "M.2 Socket 1-SD",
> > +               "M.2 Socket 2",
> > +               "M.2 Socket 3",
> > +               "MXM Type I",
> > +               "MXM Type II",
> > +               "MXM Type III",
> > +               "MXM Type III-HE",
> > +               "MXM Type IV",
> > +               "MXM 3.0 Type A",
> > +               "MXM 3.0 Type B",
> > +               "PCI Express 2 SFF-8639",
> > +               "PCI Express 2 SFF-8639" /* 0x20 */
> The last two are the same, 0x20 is gen 3, 0x1f is gen 2.

Good catch, thank you for the review. Fixed.

> maybe
> +               "PCI Express Gen 2 SFF-8639",
> +               "PCI Express Gen 3 SFF-8639" /* 0x20 */
> so it's clear what the 2 and 3 are.

I omitted the "Gen" to be consistent with the other entries in the
type_0xA0 array.

-- 
Jean Delvare
SUSE L3 Support