Dolibarr ERP & CRM » Bugs » bug #1750 Erroneous last modifications on admin/facture.php Dernières modifications
Répondre
État Détails |
Submitted on: | 21/12/2014 14:05 | | Last Modified On: | 23/12/2014 13:46 |
Submitted by: | Bahfir Abbes (bafbes) | |
Summary: | Erroneous last modifications on admin/facture.php |
Description: | It is no longer possible to select the invoice document model |
Step to reproduce bug: | Here is the diff of the correction:
@@ -500,12 +501,11 @@ print "</tr>\n";
clearstatcache();
$var=true;
-foreach ($def as $reldir)
+foreach ($conf->file->dol_document_root as $dirroot)
{
foreach (array('','/doc') as $valdir)
{
- $dir = dol_buildpath($reldir."core/modules/facture".$valdir);
-
+ $dir = $dirroot ."/core/modules/facture".$valdir;
if (is_dir($dir))
{
$handle=opendir($dir);
|
Detected in version: | 3.6.0 | | Category: | Module: Customer Invoices |
Severity: | 5 - Major | | OS Type/Version: | |
PHP version: | | | Database type and version: | |
Etat |
Status: | Need more info | | Assigned to: | Aucun |
Resolution: | Aucun | |
Commentaires- Bahfir Abbes 23/12/2014 13:51
- Hello,
I am sorry, it seems that I am missing some information to ho to get the right version in github.
I downloaded the last stable version and verified that the bug has disappeared.
I looked back in my dolibarr installation which is a pull of Github forked from the 3.6 tag and verified the last changes of this file from there and fall in the commit which introduced the error :
commit : bc0c0eeddb6ab9db20a4728ad342587f12a45881
Author: Mainmich <address@hidden> 2014-06-04 18:13:58
Title Update facture.php foreach wrong argument
Diff : @@ -500,7 +500,7 @@ print "</tr>\n";
clearstatcache();
$var=true;
-foreach ($dirmodels as $reldir)
+foreach ($def as $reldir)
{
foreach (array('','/doc') as $valdir)
{
Do you have an Idea of how that happened ?
Thanks. - Bahfir Abbes 23/12/2014 13:46
- The bug should be fixed into last stable version.
You can download last stable version onto
http://www.dolibarr.org/downloads/ - Marcos García 23/12/2014 11:08
- Are you sure? I've attached a screenshot in order for you to check that it is working for me...
- Bahfir Abbes 23/12/2014 09:49
- Hello,
The invoice configuration page at htdocs/admin/facture.php does not show the invoice documents models present in the htdocs/core/modules/facture/doc directory. - Marcos García 22/12/2014 22:08
- Sorry, can you please explain a little bit more the problem? What are you trying to do and what is the expected result?
|
|
I am sorry, it seems that I am missing some information to ho to get the right version in github.
I downloaded the last stable version and verified that the bug has disappeared.
I looked back in my dolibarr installation which is a pull of Github forked from the 3.6 tag and verified the last changes of this file from there and fall in the commit which introduced the error :
commit : bc0c0eeddb6ab9db20a4728ad342587f12a45881
Author: Mainmich <address@hidden> 2014-06-04 18:13:58
Title Update facture.php foreach wrong argument
Diff : @@ -500,7 +500,7 @@ print "</tr>\n";
clearstatcache();
$var=true;
-foreach ($dirmodels as $reldir)
+foreach ($def as $reldir)
{
foreach (array('','/doc') as $valdir)
{
Do you have an Idea of how that happened ?
Thanks.