Dolibarr ERP & CRM » Bugs » bug #1846 Browser IE11 not detectedLatest modifications
Answer now
Snapshot| Details |
| Submitted by: | Ruben Almeida (aruben) | | Submitted on: | 2015-02-13 10:43 |
| Last Modified On: | 2015-02-13 10:43 | |
| Summary: | Browser IE11 not detected |
| Description: | File : htdocs\core\lib\functions.lib.php
Functions : "getBrowserInfo"
Browser : Internet Explorer 11
Microsoft no longer uses "msie" in the HTTP_USER_AGENT for IE11 :
https://msdn.microsoft.com/en-us/library/ie/bg182625(v=vs.85).aspx
So, for IE11, the function set "$name='unknown'" & "$version=''" because it only checks "msie".
Another error:
"$phone='unkown'" instead of "$phone='unknown'" in this function (in 2 lines). |
| Step to reproduce bug: | Where :
v3.6.2: lines 150 & 139, 140
v3.6.3 (v3.6_backported): lines 150 & 139, 140
v3.7.0: lines 160 & 144, 145
v3.8 dev : lines 160 & 144, 145
Impact:
Currently, they are no impact in eldy theme, but can impact another theme if it tests the 'ie' browser to display the pages.
Solutions :
Add this test at the end of "elseif (preg_match(..." tests (after 'msie' test) :
elseif (preg_match('/trident\/([\d\.]*).*rv:([\d\.]*)/i', $_SERVER["HTTP_USER_AGENT"], $reg)) { $name='ie'; $version=$reg[2]; } // MS IE11
And correct the syntax error :
$phone='unkown' to $phone='unknown' |
| Detected in version: | 3.6.2 | | Category: | Core Problem |
| Severity: | 2 | | OS Type/Version: | |
| PHP version: | | | Database type and version: | |
| Status |
| Status: | Open | | Assigned to: | Marcos García (marcosgdf) |
| Resolution: | Fixed | |
Comments- Marcos García 2015-02-16 12:26
- The bug has been corrected. Pull request send inside GIT sources
(http://www.github.com/Dolibarr/dolibarr) and waiting to merge
into develop branch.
|
|
(http://www.github.com/Dolibarr/dolibarr) and waiting to merge
into develop branch.
in "functions.lib.php"3.7.0→ 3.6.2None→ Marcos García (marcosgdf)None→ Fixed