On Mon, Feb 24, 2014 at 4:45 PM, Doursenaud, Raphaël <address@hidden> wrote:
FWIW PSR-2 also includes PSR-1 and PSR-0.Well, Dolibarr is very far from being PSR compliant, even with the indentation (tabs instead of 4 spaces) and line length (unlimited vs, mmm well, unlimited with a recommendation to keep them under control, preferably under 120 chars, 80 chars being optimum) discrepancies.A few examples:Some Dolibarr files declare symbols and cause side effectsMost Dolibarr classes are not named in StudlyCaps.Most Dolibarr methods are not named in CamelCase()PHP closing tag is never omitted.Use of var instead of visibility in most, if not all, class propertiesVisibility is not set on most methods.Opening braces, control structures and spaces don't meet PSR-2 requirements.Now, what should we do?Keep using the legacy style or make the code PSR-2 compliant ASAP?You know I vote for the later.What about PSR-3 and PSR-4 ?I think we should adopt the whole PSR package or use any other well-defined coding style available (PEAR, Drupal, Wordpress…) rather than rolling our own.Also, other developers, you have an opinion, please chime in and speak now or forever hold your peace ;)Shall we/you/I start a poll ?
Hi, I'm not a very active person in here, but for sure one thing I agree, coding style helps readability and its always good to use it and make code be readable and nicely formatted. This in my opinion is only positive.
As for the above mentioned code non compliant issues, I just propose to fix them step by step by opening an bug for each task.
Rgds
Saxa
Cheers,2014-02-24 11:16 GMT+01:00 Destailleur Laurent <address@hidden>:
We discussed on that few month ago but i forgot to save conclusion onto developer wiki documentation. I added them onto page:
Conclusion is that we use PSR2 with 2 exceptions (see wiki updated page). And there is a checkstyle page to check we follow this.
I work with eclipse 3.7 and if you set up correctly (see page http://wiki.dolibarr.org/index.php/Environment_and_development_tools and http://wiki.dolibarr.org/index.php/Environment_and_development_tools_-_Optionnal_components), everything looks fine for me.2014-02-23 21:58 GMT+01:00 Florian Henry <address@hidden>:_______________________________________________Hi,
I was working on stuff in dev branch, and it was long time I didn't get to commit. I copy-paste some code lines from other branch or module (to integrate them into the core) and I've seen a lot of the travis "style" syntax check come into pull request.
I use Eclipse Kepler (4.3) + PDT as IDE. What is yours ?
- Notepad++
- PHP Storm
- Eclipse Indigo (3.7) + PDT
- Eclipse Helios (3.6) + PDT
- Vim
- others
This question is to know, if it's hard for you to do "auto format" code ?
After lot's of try and adjustement, I think I found a PHP->Code Style->Formatter Dolibarr syntax that is complaint with the dev/codesniffer/ruleset.xml.
I put it in attachement. Mostly base one PSR-0 (the default into Eclipse Kepler 4.3)
I think that the current code style format is the one use by default by Eclipse Indigo (3.7) or Eclipse Helios (3.6), a code style that I didn't found by defaut into Eclipse Kepler and seems not to be a PSR-0 or other standard code style PHP format.
Well, I think it would be nice to use a normalize code style format like PSR or other one. I think the devcamp will be a good time to do it. What do you think about it ?
I know I will hate myself, because when I will want to integrate some code lines from others branches I've done for some projets, a compare/diff between old and new files will thanks to me for this brilliant idea. Ok, so lets go to auto format the all code previous branch and it will do the tricks. andafter that no more problem with formating check style.
I also know that, for Dolibarr, code style PHP format is not a important matter. But if it can be done with the agreement of lot's of person it will be nice.
Regards.
--
Florian HENRY
address@hidden
+33 6 03 76 48 07
http://www.open-concept.pro
Twitter : @_Open_Concept_
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
--Laurent Destailleur (alias Eldy)------------------------------------------------------------------------------------Social networks of my OpenSource projects:Dolibarr Google+: https://plus.google.com/+DolibarrOrg/Dolibarr Facebook: https://www.facebook.com/dolibarrDolibarr Twitter: http://www.twitter.com/dolibarrAWStats Google+: https://plus.google.com/+AWStatsOrgPoject/AWStats Facebook: https://www.facebook.com/awstats.orgAWStats Twitter: http://www.twitter.com/astats_project
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
--Raphaël DoursenaudDirecteur technique (CTO)
Technopole Hélioparc2 avenue du Président Pierre Angot64053 PAU CEDEX 9SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev