Re: [Dolibarr-dev] GitHub/Travis and camel caps format

[Destailleur Laurent]

Into the travis file, check you have

--standard=dev/codesniffer/ruleset.xml

to define the rule to check.

Into this file the rule

PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

is set to 0 so disabled.

For new methods we must use camel format. For old one, i migrate slowly (few function at once for each new version).

2014-05-29 15:01 GMT+02:00 Florian HENRY <address@hidden>:

Hi all,

        I was working on mailing module and stuff, and again Travis send me error on my pull request.

        The reason is "Public method name FormMailing::select_destinaries_status is not in camel caps format"

        That true, but what to do, put new method name in camel case format or keep the old Dolibarr way and commant in travais.yum this condition ?
        The orhter point is why travis is not happy with my code, but do not warning alctual code style ?

Regards

--
Florian Henry
+33 6 03 76 48 07
address@hidden
http://www.open-concept.pro
Twitter : @_Open_Concept_


_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

--

Laurent Destailleur (alias Eldy)

------------------------------------------------------------------------------------

Social networks of my OpenSource projects:

Dolibarr Google+: https://plus.google.com/+DolibarrOrg/

Dolibarr Facebook: https://www.facebook.com/dolibarr

Dolibarr Twitter: http://www.twitter.com/dolibarr

AWStats Google+: https://plus.google.com/+AWStatsOrgPoject/

AWStats Facebook: https://www.facebook.com/awstats.org

AWStats Twitter: http://www.twitter.com/awstats_project