[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Dolibarr-git] [Dolibarr/dolibarr] 1f6ccc: Removed return from void func
|
From: |
Laurent Destailleur |
|
Subject: |
[Dolibarr-git] [Dolibarr/dolibarr] 1f6ccc: Removed return from void function |
|
Date: |
Sat, 09 Nov 2013 16:17:48 -0800 |
Branch: refs/heads/develop
Home: https://github.com/Dolibarr/dolibarr
Commit: 1f6cccc3dc8834c0db1485f5a852701a127162e6
https://github.com/Dolibarr/dolibarr/commit/1f6cccc3dc8834c0db1485f5a852701a127162e6
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/ecm/class/ecmdirectory.class.php
Log Message:
-----------
Removed return from void function
The function is declared void and the return value was not used anywhere
Commit: 638764f86d3e545ff131f47e5c48a49e3222e494
https://github.com/Dolibarr/dolibarr/commit/638764f86d3e545ff131f47e5c48a49e3222e494
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/action/class/cactioncomm.class.php
Log Message:
-----------
Moved unreachable statement to conditions
Commit: 8907c9944db8e644eeb144f42fd95e86a179bf2d
https://github.com/Dolibarr/dolibarr/commit/8907c9944db8e644eeb144f42fd95e86a179bf2d
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/action/class/actioncomm.class.php
M htdocs/comm/propal/class/propal.class.php
M htdocs/ecm/class/ecmdirectory.class.php
Log Message:
-----------
Assigments in conditions is often considered bad practice
So let's put a comment, just in case
Commit: 9e0f8c5f571e317778f917798f2220f75c2123b4
https://github.com/Dolibarr/dolibarr/commit/9e0f8c5f571e317778f917798f2220f75c2123b4
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/action/fiche.php
Log Message:
-----------
Method is void, let's not print void
Commit: fa43476890f9e5ef72b6d0ba0bfce2c2ce37b5aa
https://github.com/Dolibarr/dolibarr/commit/fa43476890f9e5ef72b6d0ba0bfce2c2ce37b5aa
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/class/commonobject.class.php
M htdocs/core/class/html.formcompany.class.php
Log Message:
-----------
Fixed methods description
These methods were declared void but actually returns values. Added proper
documentation.
Commit: 74f83b235a046ecce7a2bdb1e9f1ca757c502c57
https://github.com/Dolibarr/dolibarr/commit/74f83b235a046ecce7a2bdb1e9f1ca757c502c57
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/action/fiche.php
Log Message:
-----------
Typecasting
The GETPOST method returns string, let's make the typecast explicit.
Commit: d5ab0723bafddb10bb415c70f0f392d86eae96d4
https://github.com/Dolibarr/dolibarr/commit/d5ab0723bafddb10bb415c70f0f392d86eae96d4
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/action/class/ical.class.php
M htdocs/comm/propal/class/propal.class.php
M htdocs/core/lib/date.lib.php
M htdocs/core/lib/files.lib.php
M htdocs/core/lib/functions.lib.php
Log Message:
-----------
Timestamp is not a type
Timestamps are integers so let's document this correctly
Commit: 01ea84a917e0bda270197700063bf3101a8a9a89
https://github.com/Dolibarr/dolibarr/commit/01ea84a917e0bda270197700063bf3101a8a9a89
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/lib/functions.lib.php
Log Message:
-----------
Static members are not always strings
Update method documentation to reflect the mixed type expected
Commit: c845124b925ed0826857b628d5b2c79eb9a3cf9b
https://github.com/Dolibarr/dolibarr/commit/c845124b925ed0826857b628d5b2c79eb9a3cf9b
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/class/html.form.class.php
M htdocs/core/class/html.formcompany.class.php
M htdocs/core/class/interfaces.class.php
M htdocs/core/lib/agenda.lib.php
M htdocs/core/lib/ecm.lib.php
M htdocs/core/lib/files.lib.php
M htdocs/core/lib/functions2.lib.php
M htdocs/core/lib/propal.lib.php
M htdocs/core/modules/propale/modules_propale.php
Log Message:
-----------
Object type is lowercase
Commit: e514b50d7e016408cd24182929a11f5839372293
https://github.com/Dolibarr/dolibarr/commit/e514b50d7e016408cd24182929a11f5839372293
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/propal/class/propal.class.php
M htdocs/core/lib/files.lib.php
Log Message:
-----------
Typo fix
Commit: 9746702d783fa979113f90bb19a8cdc3b09613c9
https://github.com/Dolibarr/dolibarr/commit/9746702d783fa979113f90bb19a8cdc3b09613c9
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/ftp/index.php
Log Message:
-----------
FTP connections are resources
Avoid declaring it as int
Commit: 8e1fd7a083376a21e578be69f308e0e207e48609
https://github.com/Dolibarr/dolibarr/commit/8e1fd7a083376a21e578be69f308e0e207e48609
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/lib/functions.lib.php
Log Message:
-----------
PHP doesn't know reals, use float
Commit: 9be462e43c52936943fb985ca53d8e96d3662dc2
https://github.com/Dolibarr/dolibarr/commit/9be462e43c52936943fb985ca53d8e96d3662dc2
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/comm/propal/class/propal.class.php
Log Message:
-----------
Text is not a type, let's use string
Commit: 9faa8325605fdced7b0a6bd3db212ae6eb627b2f
https://github.com/Dolibarr/dolibarr/commit/9faa8325605fdced7b0a6bd3db212ae6eb627b2f
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/js/lib_head.js
Log Message:
-----------
Wrong var
Commit: b6eecb0394cdcff2709f2dd4d41094d0849f818f
https://github.com/Dolibarr/dolibarr/commit/b6eecb0394cdcff2709f2dd4d41094d0849f818f
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M htdocs/core/lib/pdf.lib.php
Log Message:
-----------
Developer documentation fix
Commit: 1fc2e495ba729c18578eadf338fe002f7a281c7e
https://github.com/Dolibarr/dolibarr/commit/1fc2e495ba729c18578eadf338fe002f7a281c7e
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-08 (Fri, 08 Nov 2013)
Changed paths:
M htdocs/core/lib/files.lib.php
Log Message:
-----------
Moved unreachable statement
Commit: 2b29f45a437291425b5caf3cf1641dddbb1695cc
https://github.com/Dolibarr/dolibarr/commit/2b29f45a437291425b5caf3cf1641dddbb1695cc
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-08 (Fri, 08 Nov 2013)
Changed paths:
M htdocs/ecm/class/ecmdirectory.class.php
Log Message:
-----------
Added class members that where declared dynamically
Commit: 594781ec62b1ca1baa0d6d28a3688ec093066794
https://github.com/Dolibarr/dolibarr/commit/594781ec62b1ca1baa0d6d28a3688ec093066794
Author: Raphaël Doursenaud <address@hidden>
Date: 2013-11-08 (Fri, 08 Nov 2013)
Changed paths:
M htdocs/comm/action/fiche.php
Log Message:
-----------
Codestyle
Commit: 665f4ac83a78dcf986da52c878fb9a319f8d3319
https://github.com/Dolibarr/dolibarr/commit/665f4ac83a78dcf986da52c878fb9a319f8d3319
Author: Laurent Destailleur <address@hidden>
Date: 2013-11-09 (Sat, 09 Nov 2013)
Changed paths:
M htdocs/comm/action/class/actioncomm.class.php
M htdocs/comm/action/class/cactioncomm.class.php
M htdocs/comm/action/class/ical.class.php
M htdocs/comm/action/fiche.php
M htdocs/comm/propal/class/propal.class.php
M htdocs/core/class/commonobject.class.php
M htdocs/core/class/html.form.class.php
M htdocs/core/class/html.formcompany.class.php
M htdocs/core/class/interfaces.class.php
M htdocs/core/js/lib_head.js
M htdocs/core/lib/agenda.lib.php
M htdocs/core/lib/date.lib.php
M htdocs/core/lib/ecm.lib.php
M htdocs/core/lib/files.lib.php
M htdocs/core/lib/functions.lib.php
M htdocs/core/lib/functions2.lib.php
M htdocs/core/lib/pdf.lib.php
M htdocs/core/lib/propal.lib.php
M htdocs/core/modules/propale/modules_propale.php
M htdocs/ecm/class/ecmdirectory.class.php
M htdocs/ftp/index.php
Log Message:
-----------
Merge pull request #1289 from GPCsolutions/35b-review
35b review
Compare:
https://github.com/Dolibarr/dolibarr/compare/18b55d550322...665f4ac83a78
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Dolibarr-git] [Dolibarr/dolibarr] 1f6ccc: Removed return from void function,
Laurent Destailleur <=